Sign upLogin

EGI-FCTF/oneacct_export

View on GitHub
Star
lib/one_worker.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method perform has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def perform(vms, file_number)
    OneacctExporter::Log.setup_log_level(logger)

    vms = vms.split('|')
Severity: Minor
Found in lib/one_worker.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_vm has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def process_vm(vm, user_map, image_map, cluster_map, benchmark_map)
    data = common_data
    data.merge! output_type_specific_data

    data['vm_uuid'] = vm['ID']
Severity: Minor
Found in lib/one_worker.rb - About 1 hr to fix

    Method perform has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def perform(vms, file_number)
    OneacctExporter::Log.setup_log_level(logger)

    vms = vms.split('|')
    Severity: Minor
    Found in lib/one_worker.rb - About 1 hr to fix

      Method process_vm has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def process_vm(vm, user_map, image_map, cluster_map, benchmark_map)
      Severity: Minor
      Found in lib/one_worker.rb - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status