Sign upLogin

EPForumL/androidApp

View on GitHub
Star
app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt

Summary

Maintainability
D
2 days
Test Coverage
A
96%

File QuestionDetailsActivity.kt has 297 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.github.ybecker.epforuml.basicEntities.questions

import android.content.Intent
import android.content.SharedPreferences
import android.graphics.PorterDuff
Severity: Minor
Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt - About 3 hrs to fix

    Method updateRecycler has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
    Open

        private fun updateRecycler() {

        if (MainActivity.isConnected()) {

            db.getUserById(question!!.userId).thenAccept {
    Severity: Minor
    Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method updateRecycler has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private fun updateRecycler() {

        if (MainActivity.isConnected()) {

            db.getUserById(question!!.userId).thenAccept {
    Severity: Minor
    Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt - About 1 hr to fix

      Method endorsementSetup has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private fun endorsementSetup() {
        db.getQuestionFollowers(questionId).thenAccept {
            val notificationButton = findViewById<ImageButton>(R.id.addFollowButton)
            val followButton = findViewById<TextView>(R.id.notificationCount)
            val count = it.size
      Severity: Minor
      Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt - About 1 hr to fix

        Method onCreate has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_question_details)

        audioPlayer = AndroidAudioPlayer(this)
        Severity: Minor
        Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt - About 1 hr to fix

          Method answerPostingSetup has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private fun answerPostingSetup() {
        val replyBox : EditText = findViewById(R.id.write_reply_box)
        val sendButton : ImageButton = findViewById(R.id.post_reply_button)
        val latexButton : ImageButton = findViewById(R.id.question_details_latex)
          Severity: Minor
          Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt - About 1 hr to fix

            Method answerPostingSetup has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
            Open

                private fun answerPostingSetup() {
        val replyBox : EditText = findViewById(R.id.write_reply_box)
        val sendButton : ImageButton = findViewById(R.id.post_reply_button)
        val latexButton : ImageButton = findViewById(R.id.question_details_latex)
            Severity: Minor
            Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                /**
     * Helper function for function below
     */
    inline fun <reified T> Gson.fromJson(json: String) = fromJson<T>(json, object: TypeToken<T>() {}.type)
            Severity: Major
            Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt and 2 other locations - About 1 hr to fix
            app/src/main/java/com/github/ybecker/epforuml/features/authentication/LoginActivity.kt on lines 71..74
            app/src/main/java/com/github/ybecker/epforuml/util/MainActivity.kt on lines 255..258

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 103.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        findViewById<TextView>(R.id.qdetails_question_username).text = getString(R.string.qdetail_username_text).replace("Username", username)
            Severity: Minor
            Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt and 1 other location - About 1 hr to fix
            app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt on lines 137..137

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 89.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            findViewById<TextView>(R.id.qdetails_question_username).text = getString(R.string.qdetail_username_text).replace("Username", username)
            Severity: Minor
            Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt and 1 other location - About 1 hr to fix
            app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt on lines 170..170

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 89.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (!MainActivity.isConnected()) {
            cardView.visibility = View.GONE
            sendButton.visibility = View.GONE
            saveButton.visibility = View.GONE
            latexButton.visibility = View.GONE
            Severity: Minor
            Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt and 1 other location - About 55 mins to fix
            app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt on lines 375..380

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 87.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    } else {
            cardView.visibility = View.VISIBLE
            sendButton.visibility = View.VISIBLE
            saveButton.visibility = View.VISIBLE
            latexButton.visibility = View.VISIBLE
            Severity: Minor
            Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt and 1 other location - About 55 mins to fix
            app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt on lines 370..375

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 87.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if(filteredUserList.isNotEmpty()) {
                    username = filteredUserList[0].username
                } else {
                    username = R.string.unknownUser.toString()
                }
            Severity: Minor
            Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt and 1 other location - About 45 mins to fix
            app/src/main/java/com/github/ybecker/epforuml/basicEntities/answers/SavedAnswerAdapter.kt on lines 81..85

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 77.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        } else {
                notificationButton.setColorFilter(ContextCompat.getColor(context,
                    R.color.light_gray
                ), PorterDuff.Mode.SRC_IN)
            }
            Severity: Minor
            Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt and 1 other location - About 35 mins to fix
            app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt on lines 280..282

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if(notificationActive){
                notificationButton.setColorFilter(ContextCompat.getColor(context, R.color.yellow), PorterDuff.Mode.SRC_IN)
            } else {
            Severity: Minor
            Found in app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt and 1 other location - About 35 mins to fix
            app/src/main/java/com/github/ybecker/epforuml/basicEntities/questions/QuestionDetailsActivity.kt on lines 282..286

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status