Sign upLogin

EPForumL/androidApp

View on GitHub
Star
app/src/main/java/com/github/ybecker/epforuml/database/Database.kt

Summary

Maintainability
C
1 day
Test Coverage
A
100%

Class Database has 50 methods (exceeds 20 allowed). Consider refactoring.
Open

/**
 * An abstract class that defines a set of methods to be implemented by concrete database implementations.
 */
abstract class Database {
Severity: Minor
Found in app/src/main/java/com/github/ybecker/epforuml/database/Database.kt - About 7 hrs to fix

    Method addQuestion has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        abstract fun addQuestion(userId: String, courseId: String,isAnonymous:Boolean,  questionTitle: String, questionText: String?,  image_uri: String, audioPath : String): CompletableFuture<Question>
    Severity: Major
    Found in app/src/main/java/com/github/ybecker/epforuml/database/Database.kt - About 50 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          abstract fun addQuestion(userId: String, courseId: String,isAnonymous:Boolean,  questionTitle: String, questionText: String?,  image_uri: String, audioPath : String): CompletableFuture<Question>
      Severity: Minor
      Found in app/src/main/java/com/github/ybecker/epforuml/database/Database.kt and 1 other location - About 50 mins to fix
      app/src/main/java/com/github/ybecker/epforuml/database/MockDatabase.kt on lines 168..168

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status