Sign upLogin

EPForumL/androidApp

View on GitHub
Star
app/src/main/java/com/github/ybecker/epforuml/structure/CoursesFragment.kt

Summary

Maintainability
C
7 hrs
Test Coverage
B
85%

Method bind has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
Open

        fun bind(course: Course) {
            courseTitleTextView.text = course.courseName
            subscriptionSwitch.isEnabled = user.userId.length != 0
            val is_subscribed = userSubscriptions.map { it.courseId }.contains(course.courseId)
            subscriptionSwitch.isChecked = is_subscribed
Severity: Minor
Found in app/src/main/java/com/github/ybecker/epforuml/structure/CoursesFragment.kt - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method bind has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        fun bind(course: Course) {
            courseTitleTextView.text = course.courseName
            subscriptionSwitch.isEnabled = user.userId.length != 0
            val is_subscribed = userSubscriptions.map { it.courseId }.contains(course.courseId)
            subscriptionSwitch.isChecked = is_subscribed
Severity: Minor
Found in app/src/main/java/com/github/ybecker/epforuml/structure/CoursesFragment.kt - About 1 hr to fix

    Method onBindViewHolder has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            override fun onBindViewHolder(holder: RecyclerView.ViewHolder, position: Int) {
            if(holder is CourseViewHolder){
                val course = courses[position]
                // call bind with name args and if the switch is checked or not
                holder.bind(course)
    Severity: Minor
    Found in app/src/main/java/com/github/ybecker/epforuml/structure/CoursesFragment.kt - About 1 hr to fix

      Method onBindViewHolder has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
      Open

              override fun onBindViewHolder(holder: RecyclerView.ViewHolder, position: Int) {
            if(holder is CourseViewHolder){
                val course = courses[position]
                // call bind with name args and if the switch is checked or not
                holder.bind(course)
      Severity: Minor
      Found in app/src/main/java/com/github/ybecker/epforuml/structure/CoursesFragment.kt - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              if (isChecked) {
                            // add a subscription for this user in the course
                            db.addNotification(user.userId, course.courseId)
                            Toast.makeText(itemView.context, "You allow notifications for " + course.courseName, Toast.LENGTH_SHORT).show()
                        }
      Severity: Major
      Found in app/src/main/java/com/github/ybecker/epforuml/structure/CoursesFragment.kt and 1 other location - About 1 hr to fix
      app/src/main/java/com/github/ybecker/epforuml/structure/CoursesFragment.kt on lines 189..192

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 98.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              else {
                            db.removeNotification(user.userId, course.courseId)
                            Toast.makeText(itemView.context,"You reject notifications for " + course.courseName,Toast.LENGTH_SHORT).show()
                        }
      Severity: Major
      Found in app/src/main/java/com/github/ybecker/epforuml/structure/CoursesFragment.kt and 1 other location - About 1 hr to fix
      app/src/main/java/com/github/ybecker/epforuml/structure/CoursesFragment.kt on lines 184..188

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 98.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status