Sign upLogin

EVE-Tools/node-43

View on GitHub
Star
lib/messagePipeline/orderProcessor.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function getStatisticalInformation has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getStatisticalInformation(regionID, typeID, callback) {
  //
  // Return statistical properties of given region/type pair
  //
Severity: Minor
Found in lib/messagePipeline/orderProcessor.js - About 1 hr to fix

    Function processOrder has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    function processOrder(order) {
  //
  // Calculate whether order is suspicious which is an arbitrary definition.
  // Any orders that are outside config.stdDevRejectionMultiplier standard deviations
  // of the mean AND where there are more than 5 orders of like type in the region will be flagged.
    Severity: Minor
    Found in lib/messagePipeline/orderProcessor.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function exports has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    exports = module.exports = function(resultSet, callback) {
  //
  // Annotate order messages with isSuspicious flag
  //
    Severity: Minor
    Found in lib/messagePipeline/orderProcessor.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status