Sign upLogin

EVE-Tools/node-43

View on GitHub
Star
lib/messagePipeline/orderRegionStatsHistory.js

Summary

Maintainability
D
2 days
Test Coverage

Function upsertRegionStatHistory has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function upsertRegionStatHistory(resultSet, callback) {

  var queryValues = prepareQueryValues(resultSet);

  // Get connection from pool
Severity: Minor
Found in lib/messagePipeline/orderRegionStatsHistory.js - About 1 hr to fix

    Function prepareQueryValues has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function prepareQueryValues(resultSet) {
  //
  // Prepare parametrized query for history upsert
  //
    Severity: Minor
    Found in lib/messagePipeline/orderRegionStatsHistory.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        params = '($'+(count++)+
           '::float8, $'+(count++)+
           '::float8, $'+(count++)+
           '::float8, $'+(count++)+
           '::float8, $'+(count++)+
      Severity: Major
      Found in lib/messagePipeline/orderRegionStatsHistory.js and 1 other location - About 6 hrs to fix
      lib/messagePipeline/orderRegionStats.js on lines 14..29

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 161.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            pgClient.query('INSERT INTO market_data_itemregionstathistory AS stats (buymean, ' +
                      'buyavg, ' +
                      'buymedian, ' +
                      'sellmean, ' +
                      'sellavg, ' +
      Severity: Major
      Found in lib/messagePipeline/orderRegionStatsHistory.js and 1 other location - About 4 hrs to fix
      lib/messagePipeline/orderRegionStats.js on lines 73..101

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 125.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      exports = module.exports = function(resultSet, callback) {
  //
  // Stores order statistics in itemRegionStatsHistory table
  //
      Severity: Major
      Found in lib/messagePipeline/orderRegionStatsHistory.js and 1 other location - About 2 hrs to fix
      lib/messagePipeline/orderRegionStats.js on lines 118..135

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 82.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                            'sell_std_dev = excluded.sell_std_dev', queryValues.values, function(err, result) {

        done(); // Return connection to pool

        if(err) {
      Severity: Major
      Found in lib/messagePipeline/orderRegionStatsHistory.js and 1 other location - About 1 hr to fix
      lib/messagePipeline/orderRegionStats.js on lines 102..112

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status