Sign upLogin

EaDesgin/magento2-pdf-generator2

View on GitHub
Star
Controller/Adminhtml/Templates/Save.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function execute has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute()
    {
        $data = $this->getRequest()->getPostValue();
        /** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
        $resultRedirect = $this->resultRedirectFactory->create();
Severity: Minor
Found in Controller/Adminhtml/Templates/Save.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute()
    {
        $data = $this->getRequest()->getPostValue();
        /** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
        $resultRedirect = $this->resultRedirectFactory->create();
Severity: Minor
Found in Controller/Adminhtml/Templates/Save.php - About 1 hr to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            Action\Context $context,
        PdfDataProcessor $dataProcessor,
        DataPersistorInterface $dataPersistor,
        TemplateRepository $templateRepository,
        PdfgeneratorFactory $pdfgeneratorFactory
    Severity: Minor
    Found in Controller/Adminhtml/Templates/Save.php - About 35 mins to fix

      Avoid too many return statements within this method.
      Open

              return $resultRedirect->setPath('*/*/');
      Severity: Major
      Found in Controller/Adminhtml/Templates/Save.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status