Sign upLogin

EagerELK/ditty

View on GitHub
Star

Showing 22 of 22 total issues

Method read_response has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

      def read_response(entity)
        actions = actions(entity: entity, action: :read)
        respond_to do |format|
          format.html do
            title = heading(:read) + (entity.respond_to?(:name) ? ": #{entity.name}" : '')
Severity: Minor
Found in lib/ditty/helpers/response.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File application_controller.rb has 257 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'browser/browser'
require 'wisper'
require 'oga'
require 'sinatra/base'
require 'sinatra/flash'
Severity: Minor
Found in lib/ditty/controllers/application_controller.rb - About 2 hrs to fix

    Method read_response has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def read_response(entity)
        actions = actions(entity: entity, action: :read)
        respond_to do |format|
          format.html do
            title = heading(:read) + (entity.respond_to?(:name) ? ": #{entity.name}" : '')
    Severity: Minor
    Found in lib/ditty/helpers/response.rb - About 1 hr to fix

      Method list_response has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def list_response(result, view: 'index')
        actions = actions(action: :list)
        respond_to do |format|
          format.html do
            haml :"#{view_location}/#{view}",
      Severity: Minor
      Found in lib/ditty/helpers/response.rb - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              broadcast(:application_error, env['sinatra.error'], error_code: 404, target: self)
      respond_to do |format|
        status 404
        format.html do
          haml :'404', locals: { title: '4 oh 4' }, layout: layout
        Severity: Minor
        Found in lib/ditty/controllers/application_controller.rb and 1 other location - About 1 hr to fix
        lib/ditty/controllers/application_controller.rb on lines 121..131

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              broadcast(:application_error, env['sinatra.error'], error_code: 404, target: self)
      respond_to do |format|
        status 404
        format.html do
          haml :'404', locals: { title: '4 oh 4' }, layout: layout
        Severity: Minor
        Found in lib/ditty/controllers/application_controller.rb and 1 other location - About 1 hr to fix
        lib/ditty/controllers/application_controller.rb on lines 180..190

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              error = env['sinatra.error']
      broadcast(:application_error, error, error_code: 400, target: self)
      logger.error error
      respond_to do |format|
        status 400
        Severity: Minor
        Found in lib/ditty/controllers/application_controller.rb and 1 other location - About 55 mins to fix
        lib/ditty/controllers/application_controller.rb on lines 246..256

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              error = env['sinatra.error']
      broadcast(:application_error, error, error_code: 500, target: self)
      logger.error error
      respond_to do |format|
        status 500
        Severity: Minor
        Found in lib/ditty/controllers/application_controller.rb and 1 other location - About 55 mins to fix
        lib/ditty/controllers/application_controller.rb on lines 218..228

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method actions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def actions(entity: nil, action: nil)
        actions = {}
        actions["#{base_path}/#{entity.display_id}/edit"] = "Edit #{heading}" if entity && policy(entity).update? && action != :edit
        actions[base_path] = "List #{heading(:list)}" if policy(entity || settings.model_class).list? && action != :list
        actions["#{base_path}/new"] = "New #{heading}" if policy(entity || settings.model_class).create? && action != :new
        Severity: Minor
        Found in lib/ditty/helpers/response.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method application_error has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def application_error(error, opts = {})
        return unless error.is_a? StandardError
        return unless @request_span

        request = opts[:target].request
        Severity: Minor
        Found in lib/ditty/services/open_telemetry.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method deliver! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def deliver!(to = nil, locals = {})
        options[:to] = to unless to.nil?
        @locals.merge!(locals)
        %i[to from subject content_type].each do |param|
          next unless options[param]
        Severity: Minor
        Found in lib/ditty/emails/base.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method display has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def display(value, type = :string)
        if [true, false].include?(value) || type.to_sym == :boolean
          value ? 'Yes' : 'No'
        elsif value.nil? || type.to_sym == :nil
          '(Empty)'
        Severity: Minor
        Found in lib/ditty/helpers/views.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method generate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                def generate(email, to = nil, options = {})
          config!
          options[:to] ||= to unless to.nil?
          options[:from] ||= config[:from] unless config[:from].nil?
          email = from_symbol(email, options) if email.is_a? Symbol
        Severity: Minor
        Found in lib/ditty/services/email.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method pagination has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def pagination(list, base_path, qp = {})
        return unless list.respond_to?(:pagination_record_count) || list.respond_to?(:total_entries)

        list = ::Ditty::Services::PaginationWrapper.new(list)
        locals = {
        Severity: Minor
        Found in lib/ditty/helpers/views.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

              def create_controller
        filename = File.join("lib/#{folder}/controllers", "#{controller_name.underscore}.rb")
        template '../templates/controller.rb.erb', filename
      rescue StandardError => e
        puts "Could not generate controller for #{model_name}: #{e.message}"
        Severity: Minor
        Found in lib/ditty/generators/crud_generator.rb and 3 other locations - About 30 mins to fix
        lib/ditty/generators/crud_generator.rb on lines 31..36
        lib/ditty/generators/crud_generator.rb on lines 45..50
        lib/ditty/generators/crud_generator.rb on lines 52..57

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

              def create_policy
        filename = File.join("lib/#{folder}/policies", "#{policy_name.underscore}.rb")
        template '../templates/policy.rb.erb', filename
      rescue StandardError => e
        puts "Could not generate policy for #{model_name}: #{e.message}"
        Severity: Minor
        Found in lib/ditty/generators/crud_generator.rb and 3 other locations - About 30 mins to fix
        lib/ditty/generators/crud_generator.rb on lines 31..36
        lib/ditty/generators/crud_generator.rb on lines 38..43
        lib/ditty/generators/crud_generator.rb on lines 52..57

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

              def create_type
        filename = File.join("lib/#{folder}/types", "#{model_name.underscore}_type.rb")
        template '../templates/type.rb.erb', filename
      rescue StandardError => e
        puts "Could not generate type for #{model_name}: #{e.message}"
        Severity: Minor
        Found in lib/ditty/generators/crud_generator.rb and 3 other locations - About 30 mins to fix
        lib/ditty/generators/crud_generator.rb on lines 31..36
        lib/ditty/generators/crud_generator.rb on lines 38..43
        lib/ditty/generators/crud_generator.rb on lines 45..50

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

              def create_model
        filename = File.join("lib/#{folder}/models", "#{model_name.underscore}.rb")
        template '../templates/model.rb.erb', filename
      rescue StandardError => e
        puts "Could not generate model for #{model_name}: #{e.message}"
        Severity: Minor
        Found in lib/ditty/generators/crud_generator.rb and 3 other locations - About 30 mins to fix
        lib/ditty/generators/crud_generator.rb on lines 38..43
        lib/ditty/generators/crud_generator.rb on lines 45..50
        lib/ditty/generators/crud_generator.rb on lines 52..57

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method setup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def setup
          config.compact.each_key do |provider|
            ::Ditty::Services::Logger.debug "Loading authentication provider #{provider}"
            req = if config.dig(provider, :require)
              [config[provider][:require]]
        Severity: Minor
        Found in lib/ditty/services/authentication.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method current_page_record_range has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def current_page_record_range
        if list.respond_to? :current_page_record_range
          list.current_page_record_range
        else
          return (0..0) if list.current_page > page_count
        Severity: Minor
        Found in lib/ditty/services/pagination_wrapper.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language