EasyRecon/Hunt3r

View on GitHub
backend/app/controllers/admin/tools_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method check_tools has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def check_tools(tool)
    case tool.name
    when 'amass'
      value = tool.infos['config_value']
      return 'amass_invalid' unless base64?(value)
Severity: Minor
Found in backend/app/controllers/admin/tools_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_tools has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def check_tools(tool)
    case tool.name
    when 'amass'
      value = tool.infos['config_value']
      return 'amass_invalid' unless base64?(value)
Severity: Minor
Found in backend/app/controllers/admin/tools_controller.rb - About 1 hr to fix

    Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
        tool_data = params.require(:tool).permit(:name, infos: %i[config_value user api_key url webhook])
        tool = Tool.find_by_name(tool_data[:name].downcase)
    
        if tool.nil?
    Severity: Minor
    Found in backend/app/controllers/admin/tools_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status