EclipseGc/Plugins

View on GitHub

Showing 24 of 24 total issues

Method set has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public function set(PluginDefinitionSet $set) {
    $contents = <<<EOT
<?php

use EclipseGc\Plugin\Discovery\PluginDefinitionSet;
Severity: Minor
Found in src/Cache/PHPFileCache.php - About 1 hr to fix

    Function set has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      public function set(PluginDefinitionSet $set) {
        $contents = <<<EOT
    <?php
    
    use EclipseGc\Plugin\Discovery\PluginDefinitionSet;
    Severity: Minor
    Found in src/Cache/PHPFileCache.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getDefinitions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      public function getDefinitions() : PluginDefinitionSet {
        if (is_null($this->set) && $this->cache) {
          $values = $this->cache->get();
          $this->set = $values->count() ? $values : NULL;
        }
    Severity: Minor
    Found in src/Traits/PluginDictionaryTrait.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Expected "" but found "..." for parameter type
    Open

       * @param ...$constructors

    Missing interface doc comment
    Open

    interface StaticPluginDictionaryInterface {

    Namespaced classes, interfaces and traits should not begin with a file doc comment
    Open

    /**

    Expected 1 spaces after parameter type; 0 found
    Open

       * @param \EclipseGc\Plugin\Filter\PluginDefinitionFilterInterface[] ...$filters

    Expected 1 spaces after parameter type; 0 found
    Open

       * @param \EclipseGc\Plugin\Filter\PluginDefinitionFilterInterface ...$filters

    Parameter tags must be grouped together in a doc comment
    Open

       * @param array ...$constructors

    Expected 1 spaces after parameter type; 0 found
    Open

       * @param \EclipseGc\Plugin\PluginDefinitionInterface[] ...$definitions

    Parameter tags must be grouped together in a doc comment
    Open

       * @param ...$constructors

    Parameter type "\EclipseGc\Plugin\Filter\PluginDefinitionFilterInterface[] ..." must not contain spaces
    Open

       * @param \EclipseGc\Plugin\Filter\PluginDefinitionFilterInterface[] ...$filters

    Missing trait doc comment
    Open

    trait PluginDefinitionTrait {

    Parameter type "array ..." must not contain spaces
    Open

       * @param array ...$constructors

    Parameter type "\EclipseGc\Plugin\PluginDefinitionInterface[] ..." must not contain spaces
    Open

       * @param \EclipseGc\Plugin\PluginDefinitionInterface[] ...$definitions

    Expected 1 spaces after parameter type; 0 found
    Open

       * @param \EclipseGc\Plugin\PluginDefinitionInterface ...$definitions

    Expected 1 spaces after parameter type; 0 found
    Open

       * @param array ...$constructors

    Function mutate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      public function mutate(PluginDefinitionInterface ...$definitions) : array {
        $results = [];
        foreach ($definitions as $definition) {
          if ($definition instanceof PluginDefinitionDerivativeInterface) {
            $deriver = $this->deriverResolver->getDeriverInstance($definition->getDeriver());
    Severity: Minor
    Found in src/Mutator/PluginDefinitionDeriverMutator.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Parameter type "\EclipseGc\Plugin\PluginDefinitionInterface ..." must not contain spaces
    Open

       * @param \EclipseGc\Plugin\PluginDefinitionInterface ...$definitions

    Space found before semicolon; expected "StaticPluginDictionaryInterface;" but found "StaticPluginDictionaryInterface ;"
    Open

      public function addPluginDefinition(PluginDefinitionInterface $definition) : StaticPluginDictionaryInterface ;
    Severity
    Category
    Status
    Source
    Language