Sign upLogin

ElectronicBabylonianLiterature/ebl-frontend

View on GitHub
Star
src/fragmentarium/ui/SearchForm.tsx

Summary

Maintainability
C
1 day
Test Coverage
B
80%

Function render has 168 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render(): JSX.Element {
    const rows = this.state.number?.split('\n').length ?? 0
    const numberSearchForm = (
      <Form.Group as={Row} controlId="number">
        <HelpCol overlay={MuseumSearchHelp()} />
Severity: Major
Found in src/fragmentarium/ui/SearchForm.tsx - About 6 hrs to fix

    File SearchForm.tsx has 344 lines of code (exceeds 250 allowed). Consider refactoring.
    Wontfix

    import React, { Component } from 'react'
import LuckyButton from 'fragmentarium/ui/front-page/LuckyButton'
import PioneersButton from 'fragmentarium/ui/PioneersButton'
import { withRouter, RouteComponentProps } from 'react-router-dom'
import {
    Severity: Minor
    Found in src/fragmentarium/ui/SearchForm.tsx - About 4 hrs to fix

      Function constructor has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Wontfix

        constructor(props: SearchFormProps) {
    super(props)
    this.basepath = props.project
      ? `/projects/${props.project.toLowerCase()}/search/`
      : '/fragmentarium/search/'
      Severity: Minor
      Found in src/fragmentarium/ui/SearchForm.tsx - About 1 hr to fix

        Function render has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Wontfix

          render(): JSX.Element {
    const rows = this.state.number?.split('\n').length ?? 0
    const numberSearchForm = (
      <Form.Group as={Row} controlId="number">
        <HelpCol overlay={MuseumSearchHelp()} />
        Severity: Minor
        Found in src/fragmentarium/ui/SearchForm.tsx - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Invalid

            const provenanceSearchForm = (
      <Form.Group as={Row} controlId="site">
        <HelpCol overlay={ProvenanceSearchHelp()} />
        <Col>
          <ProvenanceSearchForm
        Severity: Major
        Found in src/fragmentarium/ui/SearchForm.tsx and 1 other location - About 4 hrs to fix
        src/fragmentarium/ui/SearchForm.tsx on lines 269..280

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 122.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Invalid

            const genreSearchForm = (
      <Form.Group as={Row} controlId="genre">
        <HelpCol overlay={GenreSearchHelp()} />
        <Col>
          <GenreSearchForm
        Severity: Major
        Found in src/fragmentarium/ui/SearchForm.tsx and 1 other location - About 4 hrs to fix
        src/fragmentarium/ui/SearchForm.tsx on lines 257..268

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 122.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    onChange={(event: React.ChangeEvent<HTMLTextAreaElement>): void =>
              this.onChange('transliteration')(event.target.value)
            }
        Severity: Minor
        Found in src/fragmentarium/ui/SearchForm.tsx and 1 other location - About 50 mins to fix
        src/fragmentarium/ui/SearchForm.tsx on lines 232..234

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    onChange={(event: React.ChangeEvent<HTMLInputElement>): void =>
              this.onChange('pages')(event.target.value)
            }
        Severity: Minor
        Found in src/fragmentarium/ui/SearchForm.tsx and 1 other location - About 50 mins to fix
        src/fragmentarium/ui/SearchForm.tsx on lines 310..312

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status