Sign upLogin

EmergentOrganization/cell-rpg

View on GitHub
Star
core/src/io/github/emergentorganization/cellrpg/scenes/game/menu/pause/MovementSettingsMenu.java

Summary

Maintainability
A
2 hrs
Test Coverage

Method addMenuTableButtons has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void addMenuTableButtons() {
        // set up menu buttons:
        VisLabel controlTypeLabel = new VisLabel("weapon control scheme");
        menuTable.add(controlTypeLabel).pad(0f, 0f, 5f, 0f).fill(true, false).row();
        PlayerInputProcessor playInProc = world.getSystem(InputSystem.class).getPlayerInputProcessor();
Severity: Minor
Found in core/src/io/github/emergentorganization/cellrpg/scenes/game/menu/pause/MovementSettingsMenu.java - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            weaponControlType.addListener(
                new ChangeListener() {
                    @Override
                    public void changed(ChangeEvent event, Actor actor) {
                        // signal to movementControls new value to be set
    Severity: Minor
    Found in core/src/io/github/emergentorganization/cellrpg/scenes/game/menu/pause/MovementSettingsMenu.java and 1 other location - About 35 mins to fix
    core/src/io/github/emergentorganization/cellrpg/scenes/game/menu/pause/MovementSettingsMenu.java on lines 62..80

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            moveControlType.addListener(
                new ChangeListener() {
                    @Override
                    public void changed(ChangeEvent event, Actor actor) {
                        // signal to movementControls new value to be set
    Severity: Minor
    Found in core/src/io/github/emergentorganization/cellrpg/scenes/game/menu/pause/MovementSettingsMenu.java and 1 other location - About 35 mins to fix
    core/src/io/github/emergentorganization/cellrpg/scenes/game/menu/pause/MovementSettingsMenu.java on lines 36..54

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status