Sign upLogin

EmicoEcommerce/Magento2Tweakwise

View on GitHub
Star
Block/LayeredNavigation/RenderLayered/SwatchRenderer.php

Summary

Maintainability
C
1 day
Test Coverage

Function getSwatchData has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    public function getSwatchData()
    {
        if (false === $this->eavAttribute instanceof Attribute) {
            throw new \RuntimeException('Magento_Swatches: RenderLayered: Attribute has not been set.');
        }
Severity: Minor
Found in Block/LayeredNavigation/RenderLayered/SwatchRenderer.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getSwatchData has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getSwatchData()
    {
        if (false === $this->eavAttribute instanceof Attribute) {
            throw new \RuntimeException('Magento_Swatches: RenderLayered: Attribute has not been set.');
        }
Severity: Major
Found in Block/LayeredNavigation/RenderLayered/SwatchRenderer.php - About 2 hrs to fix

    Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            Context $context,
        Attribute $eavAttribute,
        AttributeFactory $layerAttribute,
        Data $swatchHelper,
        Media $mediaHelper,
    Severity: Major
    Found in Block/LayeredNavigation/RenderLayered/SwatchRenderer.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status