Sign upLogin

EmicoEcommerce/Magento2Tweakwise

View on GitHub
Star
Model/Catalog/Layer/Filter.php

Summary

Maintainability
C
1 day
Test Coverage

Filter has 36 functions (exceeds 20 allowed). Consider refactoring.
Open

class Filter extends AbstractFilter implements FilterInterface
{
    /**
     * @var string
     */
Severity: Minor
Found in Model/Catalog/Layer/Filter.php - About 4 hrs to fix

    File Filter.php has 272 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * Tweakwise (https://www.tweakwise.com/) - All Rights Reserved
 *
    Severity: Minor
    Found in Model/Catalog/Layer/Filter.php - About 2 hrs to fix

      Function getActiveItems has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getActiveItems()
    {
        $result = [];
        foreach ($this->getItems() as $item) {
            if (!$item->isActive()) {
      Severity: Minor
      Found in Model/Catalog/Layer/Filter.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              Layer $layer,
        FacetType $facet,
        ItemFactory $itemFactory,
        StoreManager $storeManager,
        Attribute $attribute = null
      Severity: Minor
      Found in Model/Catalog/Layer/Filter.php - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status