Sign upLogin

EmicoEcommerce/Magento2TweakwiseExport

View on GitHub
Star
Model/Write/Products.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method normalizeAttributeValue has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function normalizeAttributeValue(int $storeId, string $attributeCode, $value): array
    {
        $values = $this->ensureArray($value);
        $values = array_map(
            function ($value) {
Severity: Minor
Found in Model/Write/Products.php - About 1 hr to fix

    Function scalarValue has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function scalarValue($value)
    {
        if (is_array($value)) {
            $data = [];
            foreach ($value as $key => $childValue) {
    Severity: Minor
    Found in Model/Write/Products.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            Config $config,
        Iterator $iterator,
        StoreManager $storeManager,
        Helper $helper,
        Logger $log,
    Severity: Minor
    Found in Model/Write/Products.php - About 45 mins to fix

      Function write has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function write(Writer $writer, XMLWriter $xml, StoreInterface  $store = null): void
    {
        $xml->startElement('items');

        $stores = [];
      Severity: Minor
      Found in Model/Write/Products.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function normalizeAttributeValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function normalizeAttributeValue(int $storeId, string $attributeCode, $value): array
    {
        $values = $this->ensureArray($value);
        $values = array_map(
            function ($value) {
      Severity: Minor
      Found in Model/Write/Products.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return $values;
      Severity: Major
      Found in Model/Write/Products.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $values;
        Severity: Major
        Found in Model/Write/Products.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $result;
          Severity: Major
          Found in Model/Write/Products.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status