Sign upLogin

EndemolShineGroup/acl

View on GitHub
Star

Showing 8 of 8 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export default class DoesStep extends Step {
  havePermissions(...permissions: string[]): HaveStep {
    return new HaveStep(
      {
        ...this.query,
Severity: Major
Found in src/Steps/DoesStep.ts and 2 other locations - About 2 hrs to fix
src/Steps/DenyStep.ts on lines 6..20
src/Steps/GrantStep.ts on lines 6..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export default class GrantStep extends Step {
  permission(...permissions: string[]): GrantPermissionStep {
    return new GrantPermissionStep(
      {
        ...this.query,
Severity: Major
Found in src/Steps/GrantStep.ts and 2 other locations - About 2 hrs to fix
src/Steps/DenyStep.ts on lines 6..20
src/Steps/DoesStep.ts on lines 6..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export default class DenyStep extends Step {
  permission(...permissions: string[]): DenyPermissionStep {
    return new DenyPermissionStep(
      {
        ...this.query,
Severity: Major
Found in src/Steps/DenyStep.ts and 2 other locations - About 2 hrs to fix
src/Steps/DoesStep.ts on lines 6..20
src/Steps/GrantStep.ts on lines 6..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function toExtend has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  toExtend(roleNameToExtend: string): void {
    this.checkRolesExist();

    const roles: Roles = this.rolesStore.getRoles();
Severity: Minor
Found in src/Steps/AllowStep.ts - About 1 hr to fix

    Function for has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      for(...stages: string[]): void {
    const roles: Roles = this.rolesStore.getRoles();

    const query: GrantQuery = this.query as GrantQuery;
    Severity: Minor
    Found in src/Steps/GrantPermissionStep.ts - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        allow(...roles: string[]): AllowStep {
    return new AllowStep(
      { roles: RolesResolver(this.rolesStore, roles) },
      this.rolesStore,
    );
      Severity: Major
      Found in src/AccessControl.ts and 2 other locations - About 45 mins to fix
      src/AccessControl.ts on lines 69..74
      src/AccessControl.ts on lines 76..81

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        grant(...roles: string[]): GrantStep {
    return new GrantStep(
      { roles: RolesResolver(this.rolesStore, roles) },
      this.rolesStore,
    );
      Severity: Major
      Found in src/AccessControl.ts and 2 other locations - About 45 mins to fix
      src/AccessControl.ts on lines 62..67
      src/AccessControl.ts on lines 76..81

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        deny(...roles: string[]): DenyStep {
    return new DenyStep(
      { roles: RolesResolver(this.rolesStore, roles) },
      this.rolesStore,
    );
      Severity: Major
      Found in src/AccessControl.ts and 2 other locations - About 45 mins to fix
      src/AccessControl.ts on lines 62..67
      src/AccessControl.ts on lines 69..74

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language