EndemolShineGroup/github-backup-cli

View on GitHub

Showing 4 of 4 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  async get(repoName: string): Promise<Repo> {
    log(`Retrieving repository ${repoName} from CodeCommit...`);
    const response = await this.codeCommitSDK
      .getRepository({
        repositoryName: repoName,
Severity: Major
Found in src/Origins/CodeCommit.ts and 1 other location - About 4 hrs to fix
src/Origins/CodeCommit.ts on lines 16..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  async create(repoName: string): Promise<Repo> {
    log(`Creating repository ${repoName} on CodeCommit...`);
    const response = await this.codeCommitSDK
      .createRepository({
        repositoryName: repoName,
Severity: Major
Found in src/Origins/CodeCommit.ts and 1 other location - About 4 hrs to fix
src/Origins/CodeCommit.ts on lines 31..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function handler has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const handler = async (argv: Arguments) => {
  const { region, repoSlug } = argv;
  const [, repoName] = repoSlug.split('/');
  log(`Backing up ${repoSlug}...`);

Severity: Minor
Found in src/Commands/Backup.ts - About 1 hr to fix

    Trailing spaces
    Open

    ## Usage 
    Severity: Info
    Found in README.md by markdownlint

    MD009 - Trailing spaces

    Tags: whitespace

    Aliases: no-trailing-spaces

    Parameters: br_spaces (number; default: 0)

    This rule is triggered on any lines that end with whitespace. To fix this, find the line that is triggered and remove any trailing spaces from the end.

    The brspaces parameter allows an exception to this rule for a specific amount of trailing spaces used to insert an explicit line break/br element. For example, set brspaces to 2 to allow exactly 2 spaces at the end of a line.

    Note: you have to set brspaces to 2 or higher for this exception to take effect - you can't insert a br element with just a single trailing space, so if you set brspaces to 1, the exception will be disabled, just as if it was set to the default of 0.

    Severity
    Category
    Status
    Source
    Language