Sign upLogin

EndemolShineGroup/serverless-dynamodb-autoscaler

View on GitHub
Star

Showing 12 of 12 total issues

Function validateCapacityConfigs has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const validateCapacityConfigs = (input: any): boolean => {
  const capacities = input.service.custom.capacities;

  let isTableFirstError: boolean = true;
Severity: Minor
Found in src/utils/validation.ts - About 1 hr to fix

    Function getScalingInstruction has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const getScalingInstruction = (config: CapacityConfig, isRead: boolean) => {
  const { table, index } = config;

  const resource = ['table/', { Ref: table }];
    Severity: Minor
    Found in src/getScalingInstruction.ts - About 1 hr to fix

      Function validateInput has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const validateInput = (input: any): Promise<string> => {
  configErrors = [];

  return new Promise((resolve, reject) => {
    // Check basic serverless template input
      Severity: Minor
      Found in src/utils/validation.ts - About 1 hr to fix

        Function getScalingInstruction has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        const getScalingInstruction = (config: CapacityConfig, isRead: boolean) => {
  const { table, index } = config;

  const resource = ['table/', { Ref: table }];
        Severity: Minor
        Found in src/getScalingInstruction.ts - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

              return reject(errorMessage(getBadConfigErrorMessage()));
        Severity: Major
        Found in src/utils/validation.ts - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (target.scaleOut && !Number.isInteger(target.scaleOut)) {
        isError(config.table, OutputMessages.SCALE_MUST_BE_INTEGER);
      }
          Severity: Minor
          Found in src/utils/validation.ts and 1 other location - About 30 mins to fix
          src/utils/validation.ts on lines 80..82

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

                return reject(errorMessage(OutputMessages.NO_AUTOSCALING_CONFIG));
          Severity: Major
          Found in src/utils/validation.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return reject(errorMessage(OutputMessages.NO_AUTOSCALING_CONFIG));
            Severity: Major
            Found in src/utils/validation.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return reject(errorMessage(OutputMessages.ONLY_AWS_SUPPORT));
              Severity: Major
              Found in src/utils/validation.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return reject(errorMessage(OutputMessages.NO_AUTOSCALING_CONFIG));
                Severity: Major
                Found in src/utils/validation.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return resolve('');
                  Severity: Major
                  Found in src/utils/validation.ts - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          if (target.scaleIn && !Number.isInteger(target.scaleIn)) {
        isError(config.table, OutputMessages.SCALE_MUST_BE_INTEGER);
      }
                    Severity: Minor
                    Found in src/utils/validation.ts and 1 other location - About 30 mins to fix
                    src/utils/validation.ts on lines 83..85

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language