Consider possible security implications associated with pickle module. Open
import pickle as pkl- Exclude checks
Pickle and modules that wrap it can be unsafe when used to deserialize untrusted data, possible security issue. Open
o = pkl.load(f)- Exclude checks
Use of assert detected. The enclosed code will be removed when compiling to optimised byte code. Open
assert len(pkl_paths) != 0
- Exclude checks
Pickle and modules that wrap it can be unsafe when used to deserialize untrusted data, possible security issue. Open
o = pkl.load(f)- Exclude checks
Cyclomatic complexity is too high in function plot_solutions. (11) Open
def plot_solutions(pkl_paths: list[str], variable: str = "q") -> None:
assert len(pkl_paths) != 0
with open(pkl_paths[0], "rb") as f:
o = pkl.load(f)- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
| Construct | Effect on CC | Reasoning |
|---|---|---|
| if | +1 | An if statement is a single decision. |
| elif | +1 | The elif statement adds another decision. |
| else | +0 | The else statement does not cause a new decision. The decision is at the if. |
| for | +1 | There is a decision at the start of the loop. |
| while | +1 | There is a decision at the while statement. |
| except | +1 | Each except branch adds a new conditional path of execution. |
| finally | +0 | The finally block is unconditionally executed. |
| with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
| assert | +1 | The assert statement internally roughly equals a conditional statement. |
| Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
| Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Function plot_solutions has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
def plot_solutions(pkl_paths: list[str], variable: str = "q") -> None:
assert len(pkl_paths) != 0
with open(pkl_paths[0], "rb") as f:
o = pkl.load(f)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
if phase != 0:
axs[dof].vlines(
t_start,
bound[0],
phases_bound[phase - 1][2],Function get_dofs_name has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def get_dofs_name(nb_q):
# vanilla, with vision, with spine, with spine and vision
straight_nb_q = [10, 14, 22, 26]
pike_nb_q = [16, 20, 28, 32]
tuck_nb_q = [17, 21, 29, 33]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File not formatted according to black style guide Open
main()- Exclude checks