Sign upLogin

Eric-Guo/wechat

View on GitHub
Star
lib/action_controller/wechat_responder.rb

Summary

Maintainability
B
4 hrs
Test Coverage
A
97%

Method load_controller_wechat has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def load_controller_wechat(account, opts = {})
      cfg = Wechat.config(account)
      self.token = opts[:token] || cfg.token
      self.appid = opts[:appid] || cfg.appid
      self.corpid = opts[:corpid] || cfg.corpid
Severity: Minor
Found in lib/action_controller/wechat_responder.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_wechat_api has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def get_wechat_api(api_type, corpid, appid, secret, access_token, agentid, network_setting, jsapi_ticket, qcloud_setting)
Severity: Major
Found in lib/action_controller/wechat_responder.rb - About 1 hr to fix

    Method load_controller_wechat has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def load_controller_wechat(account, opts = {})
      cfg = Wechat.config(account)
      self.token = opts[:token] || cfg.token
      self.appid = opts[:appid] || cfg.appid
      self.corpid = opts[:corpid] || cfg.corpid
    Severity: Minor
    Found in lib/action_controller/wechat_responder.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status