Eric-Guo/wechat

View on GitHub
lib/generators/wechat/templates/app/models/wechat_config.rb

Summary

Maintainability
A
55 mins
Test Coverage
A
100%

Method app_config_is_valid has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def app_config_is_valid
    if self[:appid].present?
      # public account
      errors.add(:secret, 'cannot be nil when appid is set') if self[:secret].blank?
    elsif self[:corpid].present?
Severity: Minor
Found in lib/generators/wechat/templates/app/models/wechat_config.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status