Sign upLogin

EscolaLMS/API

View on GitHub
Star
app/Http/Controllers/Controller.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function return_output has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function return_output($type, $status_title, $message, $redirect_url, $status_code = ''): RedirectResponse
    {
        //$type = error/flash - error on form validations, flash to show session values
        //$status_title = success/error/info - change colors in toastr as per the status
Severity: Minor
Found in app/Http/Controllers/Controller.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method return_output has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function return_output($type, $status_title, $message, $redirect_url, $status_code = ''): RedirectResponse
Severity: Minor
Found in app/Http/Controllers/Controller.php - About 35 mins to fix

    Avoid too many return statements within this method.
    Open

                    return Session::flash($status_title, $message);
    Severity: Major
    Found in app/Http/Controllers/Controller.php - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status