EscolaLMS/Auth

View on GitHub

Showing 24 of 31 total issues

Method searchAndPaginate has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function searchAndPaginate(CriteriaDto $criteriaDto, array $appends = [], int $perPage = null, int $page = null, ?OrderDto $orderDto = null): LengthAwarePaginator;
Severity: Minor
Found in src/Services/Contracts/UserGroupServiceContract.php - About 35 mins to fix

    Method searchAndPaginate has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function searchAndPaginate(CriteriaDto $criteriaDto, array $appends = [], int $perPage = null, int $page = null, ?OrderDto $orderDto = null): LengthAwarePaginator
    Severity: Minor
    Found in src/Services/UserGroupService.php - About 35 mins to fix

      Function handle has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function handle(AccountDeleted $event): void
          {
              $user = $event->getUser();
              
              $columns = $this->getProcessableColumns($user);
      Severity: Minor
      Found in src/Listeners/MaskUserData.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function login(string $email, string $password): User
          {
      
              $user = $this->userRepository->findByEmail($email);
      
      
      Severity: Minor
      Found in src/Services/UserService.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language