Sign upLogin

EscolaLMS/Auth

View on GitHub
Star

Showing 33 of 33 total issues

UserService has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class UserService implements UserServiceContract
{
    private UserRepositoryContract $userRepository;

    /**
Severity: Minor
Found in src/Services/UserService.php - About 2 hrs to fix

    Method run has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function run()
    {
        $admin   = Role::findOrCreate(UserRole::ADMIN, 'api');
        $tutor   = Role::findOrCreate(UserRole::TUTOR, 'api');
        $student =  Role::findOrCreate(UserRole::STUDENT, 'api');
    Severity: Major
    Found in database/seeders/AuthPermissionSeeder.php - About 2 hrs to fix

      Method instantiateFromRequest has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function instantiateFromRequest(Request $request): self
    {
        $criteria = new Collection();

        if ($request->get('search')) {
      Severity: Minor
      Found in src/Dtos/UserFilterCriteriaDto.php - About 1 hr to fix

        Function putUsingDto has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function putUsingDto(UserUpdateDto $dto, int $id): User
    {
        $data = $dto->toArray();

        $user = $this->userRepository->update($data, $id);
        Severity: Minor
        Found in src/Services/UserService.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function patchUsingDto has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function patchUsingDto(UserUpdateDto $dto, UserUpdateKeysDto $keysDto, int $id): User
    {
        $data = $dto->toArray();

        $user = $this->userRepository->update($data, $id);
        Severity: Minor
        Found in src/Services/UserService.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 11 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct(bool $firstName = false, bool $lastName = false, bool $age = false, bool $gender = false, bool $country = false, bool $city = false, bool $street = false, bool $postcode = false, bool $email = false, bool $roles = false, bool $password = false)
        Severity: Major
        Found in src/Dtos/Admin/UserUpdateKeysDto.php - About 1 hr to fix

          Method searchNameWithBreadcrumbs has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function searchNameWithBreadcrumbs(Builder $q, string $driver, string $like): Builder
    {
        $cast = 'name::varchar';
        // check mysql version
        if ($driver !== 'pgsql') {
          Severity: Minor
          Found in src/Repositories/Criteria/UserGroupSearchCriterion.php - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function listWithUsers(UserGroupListRequest $request): JsonResponse
    {
        $filterDto = UserGroupFilterCriteriaDto::instantiateFromRequest($request);
        $paginator = $this->userGroupService->searchAndPaginate($filterDto, $request->except('page'), $request->get('per_page'), $request->get('page'), OrderDto::instantiateFromRequest($request));
            Severity: Major
            Found in src/Http/Controllers/Admin/UserGroupsController.php and 1 other location - About 1 hr to fix
            src/Http/Controllers/Admin/UserGroupsController.php on lines 34..39

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function listGroups(UserGroupListRequest $request): JsonResponse
    {
        $filterDto = UserGroupFilterCriteriaDto::instantiateFromRequest($request);
        $paginator = $this->userGroupService->searchAndPaginate($filterDto, $request->except('page'), $request->get('per_page'), $request->get('page'), OrderDto::instantiateFromRequest($request));
        return $this->sendResponseForResource(UserGroupResource::collection($paginator), __('Group list'));
            Severity: Major
            Found in src/Http/Controllers/Admin/UserGroupsController.php and 1 other location - About 1 hr to fix
            src/Http/Controllers/Admin/UserGroupsController.php on lines 48..54

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function instantiateFromRequest has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function instantiateFromRequest(Request $request): self
    {
        $criteria = new Collection();

        if ($request->get('search')) {
            Severity: Minor
            Found in src/Dtos/UserFilterCriteriaDto.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method toArray has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function toArray($request)
    {
        $fields = array_filter([
            'id' => $this->resource->getKey(),
            'name' => $this->resource->name,
            Severity: Minor
            Found in src/Http/Resources/UserResource.php - About 1 hr to fix

              Method rules has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function rules()
    {
        $rules = [
            'first_name' => ['required', 'string', 'max:255', new NoHtmlTags()],
            'last_name' => ['required', 'string', 'max:255', new NoHtmlTags()],
              Severity: Minor
              Found in src/Http/Requests/Admin/UserCreateRequest.php - About 1 hr to fix

                Method getReturnUrl has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getReturnUrl(string $provider, ?string $returnUrl, ?string $state): string
    {
        $socialUser = Socialite::driver($provider)->stateless()->user();
        $socialAccount = $this->socialAccountRepository->findByProviderAndProviderId($provider, $socialUser->getId());
                Severity: Minor
                Found in src/Services/SocialAccountService.php - About 1 hr to fix

                  Method rules has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function rules()
    {
        $rules =  [
            'first_name' => ['required', 'string', 'max:255', new NoHtmlTags()],
            'last_name' => ['required', 'string', 'max:255', new NoHtmlTags()],
                  Severity: Minor
                  Found in src/Http/Requests/RegisterRequest.php - About 1 hr to fix

                    Method rules has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function rules()
    {
        $rules = [
            'first_name' => [$this->requiredIfPut(), 'string', 'max:255', new NoHtmlTags()],
            'last_name' => [$this->requiredIfPut(), 'string', 'max:255', new NoHtmlTags()],
                    Severity: Minor
                    Found in src/Http/Requests/Admin/UserUpdateRequest.php - About 1 hr to fix

                      Method register has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function register(RegisterRequest $request): JsonResponse
    {
        $mustBeEnabledByAdmin = Config::get(
            EscolaLmsAuthServiceProvider::CONFIG_KEY . '.account_must_be_enabled_by_admin', SettingStatusEnum::DISABLED
        );
                      Severity: Minor
                      Found in src/Http/Controllers/RegisterApiController.php - About 1 hr to fix

                        Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function __construct(bool $firstName = false, bool $lastName = false, bool $age = false, bool $gender = false, bool $country = false, bool $city = false, bool $street = false, bool $postcode = false)
                        Severity: Major
                        Found in src/Dtos/UserUpdateKeysDto.php - About 1 hr to fix

                          Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  string $firstName,
        string $lastName,
        bool $isActive,
        array $roles,
        ?string $email = null,
                          Severity: Major
                          Found in src/Dtos/UserSaveDto.php - About 1 hr to fix

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                public function patchUserSettings(UserSettingsUpdateRequest $request): JsonResponse
    {
        $user = $this->fetchRequestedUser($request);
        $dto = UserUpdateSettingsDto::instantiateFromRequest($request);
        try {
                            Severity: Major
                            Found in src/Http/Controllers/Admin/UserSettingsController.php and 2 other locations - About 55 mins to fix
                            src/Http/Controllers/Admin/UserInterestsController.php on lines 24..34
                            src/Http/Controllers/Admin/UserSettingsController.php on lines 34..44

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 99.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                public function putUserSettings(UserSettingsUpdateRequest $request): JsonResponse
    {
        $user = $this->fetchRequestedUser($request);
        $dto = UserUpdateSettingsDto::instantiateFromRequest($request);
        try {
                            Severity: Major
                            Found in src/Http/Controllers/Admin/UserSettingsController.php and 2 other locations - About 55 mins to fix
                            src/Http/Controllers/Admin/UserInterestsController.php on lines 24..34
                            src/Http/Controllers/Admin/UserSettingsController.php on lines 22..32

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 99.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Severity
                            Category
                            Status
                            Source
                            Language