database/factories/ConsultationProposedTermFactory.php
Avoid using static access to class '\EscolaLms\Consultations\Models\Consultation' in method 'definition'. Open
Open
$consultation = Consultation::firstOrCreate();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Reference to undeclared property \EscolaLms\Consultations\Database\Factories\ConsultationProposedTermFactory->faker Open
Open
'proposed_at' => $this->faker->dateTimeBetween($consultation->active_from, $consultation->active_to),- Exclude checks
Static call to undeclared method \EscolaLms\Consultations\Models\Consultation::firstOrCreate Open
Open
$consultation = Consultation::firstOrCreate();- Exclude checks
Class extends undeclared class \Illuminate\Database\Eloquent\Factories\Factory Open
Open
class ConsultationProposedTermFactory extends Factory- Exclude checks