Sign upLogin

EscolaLMS/Consultations

View on GitHub
Star
database/migrations/2022_02_02_135907_create_consultations_participants_table.php

Summary

Maintainability
A
3 hrs
Test Coverage

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'up'.
Open

        Schema::create('consultations_participants', function (Blueprint $table) {
            $table->id();
            $table->bigInteger('consultation_id')->unsigned()->index();
            $table->bigInteger('user_id')->unsigned()->nullable();
            $table->string('status')->default(null)->nullable();
Severity: Minor
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'down'.
Open

        Schema::dropIfExists('consultations_participants');
Severity: Minor
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Parameter $table has undeclared type \Illuminate\Database\Schema\Blueprint
Open

        Schema::create('consultations_participants', function (Blueprint $table) {
Severity: Minor
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phan

Call to method id from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->id();
Severity: Critical
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phan

Call to method foreign from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->foreign('user_id')->references('id')->on('users')->onDelete('SET NULL');
Severity: Critical
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phan

Call to method create from undeclared class \Illuminate\Support\Facades\Schema
Open

        Schema::create('consultations_participants', function (Blueprint $table) {
Severity: Critical
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phan

Call to method foreign from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->foreign('consultation_id')->references('id')->on('consultations')->onDelete('CASCADE');
Severity: Critical
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phan

Call to method bigInteger from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->bigInteger('consultation_id')->unsigned()->index();
Severity: Critical
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phan

Class extends undeclared class \Illuminate\Database\Migrations\Migration
Open

class CreateConsultationsParticipantsTable extends Migration
Severity: Critical
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phan

Call to method bigInteger from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->bigInteger('user_id')->unsigned()->nullable();
Severity: Critical
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phan

Call to method string from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->string('status')->default(null)->nullable();
Severity: Critical
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phan

Call to method timestamps from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->timestamps();
Severity: Critical
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phan

Call to method dropIfExists from undeclared class \Illuminate\Support\Facades\Schema
Open

        Schema::dropIfExists('consultations_participants');
Severity: Critical
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phan

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function up(): void
    {
        Schema::create('consultations_participants', function (Blueprint $table) {
            $table->id();
            $table->bigInteger('consultation_id')->unsigned()->index();
Severity: Major
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php and 1 other location - About 3 hrs to fix
database/migrations/2022_02_15_104923_remove_participant_table.php on lines 14..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid using short method names like CreateConsultationsParticipantsTable::up(). The configured minimum method name length is 3.
Open

    public function up(): void
    {
        Schema::create('consultations_participants', function (Blueprint $table) {
            $table->id();
            $table->bigInteger('consultation_id')->unsigned()->index();
Severity: Minor
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class CreateConsultationsParticipantsTable extends Migration
Severity: Minor
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phpcodesniffer

There are no issues that match your filters.

Category
Status