EscolaLMS/Consultations

View on GitHub
src/Dto/Contracts/ModelDtoContract.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

The method toArray has a boolean flag argument $filters, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function toArray($filters = false): array;

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Return type of model() is undeclared type \Illuminate\Database\Eloquent\Model
Open

    public function model(): Model;
Severity: Minor
Found in src/Dto/Contracts/ModelDtoContract.php by phan

There are no issues that match your filters.

Category
Status