EscolaLMS/Consultations

View on GitHub
src/Http/Requests/ChangeTermConsultationRequest.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid using static access to class '\Illuminate\Support\Facades\Gate' in method 'authorize'.
Open

        return Gate::allows(ConsultationsPermissionsEnum::CONSULTATION_CHANGE_TERM, ConsultationUserPivot::class);

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Class extends undeclared class \Illuminate\Foundation\Http\FormRequest
Open

class ChangeTermConsultationRequest extends FormRequest

Call to method __construct from undeclared class \EscolaLms\Consultations\Rules\UserTermExist
Open

            'term' => ['required', 'date', new UserTermExist(request('consultationTermId') ? (int) request('consultationTermId') : null)],

Call to method allows from undeclared class \Illuminate\Support\Facades\Gate
Open

        return Gate::allows(ConsultationsPermissionsEnum::CONSULTATION_CHANGE_TERM, ConsultationUserPivot::class);

Call to undeclared function \request()
Open

            'term' => ['required', 'date', new UserTermExist(request('consultationTermId') ? (int) request('consultationTermId') : null)],

Line exceeds 120 characters; contains 138 characters
Open

            'term' => ['required', 'date', new UserTermExist(request('consultationTermId') ? (int) request('consultationTermId') : null)],

There are no issues that match your filters.

Category
Status