src/Http/Requests/ConsultationRequest.php
Avoid using static access to class '\EscolaLms\Consultations\Models\Consultation' in method 'getConsultation'. Open
Open
$consultation = Consultation::find($id ?? $this->getRouteIdParameter());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Class extends undeclared class \Illuminate\Foundation\Http\FormRequest Open
Open
abstract class ConsultationRequest extends FormRequest- Exclude checks
Static call to undeclared method \EscolaLms\Consultations\Models\Consultation::find Open
Open
$consultation = Consultation::find($id ?? $this->getRouteIdParameter());- Exclude checks
Call to undeclared method \EscolaLms\Consultations\Http\Requests\ConsultationRequest::route Open
Open
$result = $this->route('consultation') ?? $this->route('id');- Exclude checks
Avoid variables with short names like $id. Configured minimum length is 3. Open
Open
public function getConsultation(?int $id = null): Consultation- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}