Sign upLogin

EscolaLMS/Consultations

View on GitHub
Star
src/Http/Requests/ListAPIConsultationsRequest.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Possibly zero references to use statement for classlike/namespace Consultation (\EscolaLms\Consultations\Models\Consultation)
Open

use EscolaLms\Consultations\Models\Consultation;
Severity: Minor
Found in src/Http/Requests/ListAPIConsultationsRequest.php by phan

Possibly zero references to use statement for classlike/namespace ConsultationsPermissionsEnum (\EscolaLms\Consultations\Enum\ConsultationsPermissionsEnum)
Open

use EscolaLms\Consultations\Enum\ConsultationsPermissionsEnum;
Severity: Minor
Found in src/Http/Requests/ListAPIConsultationsRequest.php by phan

Possibly zero references to use statement for classlike/namespace Gate (\Illuminate\Support\Facades\Gate)
Open

use Illuminate\Support\Facades\Gate;
Severity: Minor
Found in src/Http/Requests/ListAPIConsultationsRequest.php by phan

Class extends undeclared class \Illuminate\Foundation\Http\FormRequest
Open

class ListAPIConsultationsRequest extends FormRequest
Severity: Critical
Found in src/Http/Requests/ListAPIConsultationsRequest.php by phan

Define a constant instead of duplicating this literal "string" 3 times.
Open

            'name' => ['string'],
Severity: Critical
Found in src/Http/Requests/ListAPIConsultationsRequest.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

There are no issues that match your filters.

Category
Status