EscolaLMS/Consultations

View on GitHub
src/Http/Requests/ScheduleConsultationAPIRequest.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid using static access to class '\Illuminate\Support\Facades\Gate' in method 'authorize'.
Open

        return Gate::allows('list', Consultation::class);

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Validation\Rule' in method 'rules'.
Open

            'status' => ['string', Rule::in(ConsultationTermStatusEnum::getValues())],

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EscolaLms\Consultations\Enum\ConsultationTermStatusEnum' in method 'rules'.
Open

            'status' => ['string', Rule::in(ConsultationTermStatusEnum::getValues())],

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to method allows from undeclared class \Illuminate\Support\Facades\Gate
Open

        return Gate::allows('list', Consultation::class);

Static call to undeclared method \EscolaLms\Consultations\Enum\ConsultationTermStatusEnum::getValues
Open

            'status' => ['string', Rule::in(ConsultationTermStatusEnum::getValues())],

Call to method in from undeclared class \Illuminate\Validation\Rule
Open

            'status' => ['string', Rule::in(ConsultationTermStatusEnum::getValues())],

There are no issues that match your filters.

Category
Status