Sign upLogin

EscolaLMS/Consultations

View on GitHub
Star
src/Http/Requests/ScheduleConsultationRequest.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid using static access to class '\Illuminate\Support\Facades\Gate' in method 'authorize'.
Open

        return Gate::allows('read', $this->getConsultation());
Severity: Minor
Found in src/Http/Requests/ScheduleConsultationRequest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EscolaLms\Consultations\Enum\ConsultationTermStatusEnum' in method 'rules'.
Open

            'status' => ['string', Rule::in(ConsultationTermStatusEnum::getValues())],
Severity: Minor
Found in src/Http/Requests/ScheduleConsultationRequest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Validation\Rule' in method 'rules'.
Open

            'status' => ['string', Rule::in(ConsultationTermStatusEnum::getValues())],
Severity: Minor
Found in src/Http/Requests/ScheduleConsultationRequest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Possibly zero references to use statement for classlike/namespace FormRequest (\Illuminate\Foundation\Http\FormRequest)
Open

use Illuminate\Foundation\Http\FormRequest;
Severity: Minor
Found in src/Http/Requests/ScheduleConsultationRequest.php by phan

Call to method allows from undeclared class \Illuminate\Support\Facades\Gate
Open

        return Gate::allows('read', $this->getConsultation());
Severity: Critical
Found in src/Http/Requests/ScheduleConsultationRequest.php by phan

Call to method in from undeclared class \Illuminate\Validation\Rule
Open

            'status' => ['string', Rule::in(ConsultationTermStatusEnum::getValues())],
Severity: Critical
Found in src/Http/Requests/ScheduleConsultationRequest.php by phan

Static call to undeclared method \EscolaLms\Consultations\Enum\ConsultationTermStatusEnum::getValues
Open

            'status' => ['string', Rule::in(ConsultationTermStatusEnum::getValues())],
Severity: Critical
Found in src/Http/Requests/ScheduleConsultationRequest.php by phan

Possibly zero references to use statement for classlike/namespace ConsultationsPermissionsEnum (\EscolaLms\Consultations\Enum\ConsultationsPermissionsEnum)
Open

use EscolaLms\Consultations\Enum\ConsultationsPermissionsEnum;
Severity: Minor
Found in src/Http/Requests/ScheduleConsultationRequest.php by phan

Possibly zero references to use statement for classlike/namespace Consultation (\EscolaLms\Consultations\Models\Consultation)
Open

use EscolaLms\Consultations\Models\Consultation;
Severity: Minor
Found in src/Http/Requests/ScheduleConsultationRequest.php by phan

There are no issues that match your filters.

Category
Status