Sign upLogin

EscolaLMS/Consultations

View on GitHub
Star
src/Http/Requests/StoreConsultationRequest.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid using static access to class '\Illuminate\Support\Facades\Gate' in method 'authorize'.
Open

        return Gate::allows('create', Consultation::class);
Severity: Minor
Found in src/Http/Requests/StoreConsultationRequest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Validation\Rule' in method 'rules'.
Open

            'status' => ['required', 'string', Rule::in(ConsultationStatusEnum::getValues())],
Severity: Minor
Found in src/Http/Requests/StoreConsultationRequest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EscolaLms\Consultations\Enum\ConsultationStatusEnum' in method 'rules'.
Open

            'status' => ['required', 'string', Rule::in(ConsultationStatusEnum::getValues())],
Severity: Minor
Found in src/Http/Requests/StoreConsultationRequest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EscolaLms\ModelFields\Facades\ModelFields' in method 'rules'.
Open

        ], ModelFields::getFieldsMetadataRules(Consultation::class));
Severity: Minor
Found in src/Http/Requests/StoreConsultationRequest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Define a constant instead of duplicating this literal "required" 3 times.
Open

            'name' => ['required', 'string', 'max:255', 'min:3'],
Severity: Critical
Found in src/Http/Requests/StoreConsultationRequest.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "string" 4 times.
Open

            'name' => ['required', 'string', 'max:255', 'min:3'],
Severity: Critical
Found in src/Http/Requests/StoreConsultationRequest.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "array" 3 times.
Open

            'proposed_dates' => ['array'],
Severity: Critical
Found in src/Http/Requests/StoreConsultationRequest.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "integer" 4 times.
Open

            'author_id' => ['integer', 'exists:users,id'],
Severity: Critical
Found in src/Http/Requests/StoreConsultationRequest.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Static call to undeclared method \EscolaLms\Consultations\Enum\ConsultationStatusEnum::getValues
Open

            'status' => ['required', 'string', Rule::in(ConsultationStatusEnum::getValues())],
Severity: Critical
Found in src/Http/Requests/StoreConsultationRequest.php by phan

Call to method getFieldsMetadataRules from undeclared class \EscolaLms\ModelFields\Facades\ModelFields
Open

        ], ModelFields::getFieldsMetadataRules(Consultation::class));
Severity: Critical
Found in src/Http/Requests/StoreConsultationRequest.php by phan

Call to method allows from undeclared class \Illuminate\Support\Facades\Gate
Open

        return Gate::allows('create', Consultation::class);
Severity: Critical
Found in src/Http/Requests/StoreConsultationRequest.php by phan

Call to method in from undeclared class \Illuminate\Validation\Rule
Open

            'status' => ['required', 'string', Rule::in(ConsultationStatusEnum::getValues())],
Severity: Critical
Found in src/Http/Requests/StoreConsultationRequest.php by phan

Class extends undeclared class \Illuminate\Foundation\Http\FormRequest
Open

class StoreConsultationRequest extends FormRequest
Severity: Critical
Found in src/Http/Requests/StoreConsultationRequest.php by phan

There are no issues that match your filters.

Category
Status