Avoid using static access to class '\EscolaLms\Consultations\Enum\ConsultationStatusEnum' in method 'rules'. Open
'status' => ['string', Rule::in(ConsultationStatusEnum::getValues())],- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Illuminate\Validation\Rule' in method 'rules'. Open
'status' => ['string', Rule::in(ConsultationStatusEnum::getValues())],- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\EscolaLms\ModelFields\Facades\ModelFields' in method 'rules'. Open
], ModelFields::getFieldsMetadataRules(Consultation::class));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Illuminate\Support\Facades\Gate' in method 'authorize'. Open
return Gate::allows('update', $this->getConsultation());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Define a constant instead of duplicating this literal "integer" 3 times. Open
'author_id' => ['integer', 'exists:users,id'],- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "string" 4 times. Open
'name' => ['string', 'max:255', 'min:3'],- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Call to method allows from undeclared class \Illuminate\Support\Facades\Gate Open
return Gate::allows('update', $this->getConsultation());- Exclude checks
Call to method getFieldsMetadataRules from undeclared class \EscolaLms\ModelFields\Facades\ModelFields Open
], ModelFields::getFieldsMetadataRules(Consultation::class));- Exclude checks
Call to method in from undeclared class \Illuminate\Validation\Rule Open
'status' => ['string', Rule::in(ConsultationStatusEnum::getValues())],- Exclude checks
Call to undeclared method \EscolaLms\Consultations\Http\Requests\UpdateConsultationRequest::route Open
$prefixPath = ConstantEnum::DIRECTORY . '/' . $this->route('id');- Exclude checks
Call to method __construct from undeclared class \EscolaLms\Files\Rules\FileOrStringRule Open
'image' => [new FileOrStringRule(['image'], $prefixPath)],- Exclude checks
Static call to undeclared method \EscolaLms\Consultations\Enum\ConsultationStatusEnum::getValues Open
'status' => ['string', Rule::in(ConsultationStatusEnum::getValues())],- Exclude checks