EscolaLMS/Consultations

View on GitHub
src/Listeners/ReminderAboutTermListener.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

syntax error, unexpected 'ConsultationServiceContract' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open

    private ConsultationServiceContract $consultationServiceContract;

Avoid excessively long variable names like $consultationServiceContract. Keep variable name length under 20.
Open

        ConsultationServiceContract $consultationServiceContract

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $consultationServiceContract. Keep variable name length under 20.
Open

    private ConsultationServiceContract $consultationServiceContract;

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Line exceeds 120 characters; contains 149 characters
Open

        $this->consultationServiceContract->setReminderStatus($event->getConsultationTerm(), $event->getStatus(), $event->getConsultationUserTerm());

There are no issues that match your filters.

Category
Status