EscolaLMS/Consultations

View on GitHub
src/Repositories/ConsultationUserRepository.php

Summary

Maintainability
A
0 mins
Test Coverage
A
94%

syntax error, unexpected '$query' (T_VARIABLE), expecting ',' or ')'
Open

        $query->whereHas('consultation', fn (Builder $query) => $query->whereAuthorId(auth()->user()->getKey()));

Avoid excessively long variable names like $filterConsultationTermsListDto. Keep variable name length under 20.
Open

        ?FilterConsultationTermsListDto $filterConsultationTermsListDto = null

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $consultationUserPivot. Keep variable name length under 20.
Open

    public function updateModel(ConsultationUserPivot $consultationUserPivot, array $data): ConsultationUserPivot

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The closing brace for the class must go on the next line after the body
Open

}

Line exceeds 120 characters; contains 121 characters
Open

        $query->whereIn('executed_status', [ConsultationTermStatusEnum::APPROVED, ConsultationTermStatusEnum::REPORTED]);

Space before opening parenthesis of function call prohibited
Open

        $query->whereHas('consultation', fn (Builder $query) => $query->whereAuthorId(auth()->user()->getKey()));

There are no issues that match your filters.

Category
Status