Sign upLogin

EscolaLMS/Consultations

View on GitHub
Star
src/routes.php

Summary

Maintainability
A
0 mins
Test Coverage

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationAPIController
Open

    Route::get('/proposed-terms/{consultationTermId}', [ConsultationAPIController::class, 'proposedTerms']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationController
Open

    Route::get('consultations/{id}/schedule', [ConsultationController::class, 'schedule']);
Severity: Critical
Found in src/routes.php by phan

Call to method post from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::post('consultations/change-term/{consultationTermId}', [ConsultationController::class, 'changeTerm']);
Severity: Critical
Found in src/routes.php by phan

Call to method group from undeclared class \Illuminate\Support\Facades\Route
Open

Route::group(['middleware' => ['auth:api'], 'prefix' => 'api/consultations'], function () {
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationAPIController
Open

    Route::get('/reject-term/{consultationTermId}', [ConsultationAPIController::class, 'rejectTerm']);
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('/reject-term/{consultationTermId}', [ConsultationAPIController::class, 'rejectTerm']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationAPIController
Open

    Route::get('/generate-jitsi/{consultationTermId}', [ConsultationAPIController::class, 'generateJitsi']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationController
Open

    Route::resource('consultations', ConsultationController::class);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationAPIController
Open

    Route::get('/{id}', [ConsultationAPIController::class, 'show']);
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('/{id}', [ConsultationAPIController::class, 'show']);
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('consultations/users/assignable', [ConsultationController::class, 'assignableUsers']);
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('/me', [ConsultationAPIController::class, 'forCurrentUser']);
Severity: Critical
Found in src/routes.php by phan

Call to method post from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::post('consultations/{id}', [ConsultationController::class, 'update']);
Severity: Critical
Found in src/routes.php by phan

Call to method post from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::post('/report-term/{consultationTermId}', [ConsultationAPIController::class, 'reportTerm']);
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('/approve-term/{consultationTermId}', [ConsultationAPIController::class, 'approveTerm']);
Severity: Critical
Found in src/routes.php by phan

Call to method post from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::post('/finish-term/{consultationTermId}', [ConsultationAPIController::class, 'finishTerm']);
Severity: Critical
Found in src/routes.php by phan

Call to method group from undeclared class \Illuminate\Support\Facades\Route
Open

Route::group(['prefix' => 'api/consultations'], function () {
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('/', [ConsultationAPIController::class, 'index']);
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('consultations/{id}/schedule', [ConsultationController::class, 'schedule']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationAPIController
Open

    Route::post('/report-term/{consultationTermId}', [ConsultationAPIController::class, 'reportTerm']);
Severity: Critical
Found in src/routes.php by phan

Call to method post from undeclared class \Illuminate\Support\Facades\Route
Open

Route::post('api/consultations/save-screen', [ConsultationAPIController::class, 'screenSave']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationController
Open

    Route::get('consultations/users/assignable', [ConsultationController::class, 'assignableUsers']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationAPIController
Open

    Route::get('/my-schedule', [ConsultationAPIController::class, 'schedule']);
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('/proposed-terms/{consultationTermId}', [ConsultationAPIController::class, 'proposedTerms']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationAPIController
Open

    Route::get('/', [ConsultationAPIController::class, 'index']);
Severity: Critical
Found in src/routes.php by phan

Call to method group from undeclared class \Illuminate\Support\Facades\Route
Open

Route::group(['middleware' => ['auth:api'], 'prefix' => 'api/admin'], function () {
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationAPIController
Open

    Route::get('/approve-term/{consultationTermId}', [ConsultationAPIController::class, 'approveTerm']);
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('/generate-jitsi/{consultationTermId}', [ConsultationAPIController::class, 'generateJitsi']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationController
Open

    Route::post('/change-term/{consultationTermId}', [ConsultationController::class, 'changeTerm']);
Severity: Critical
Found in src/routes.php by phan

Call to method resource from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::resource('consultations', ConsultationController::class);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationController
Open

    Route::post('consultations/{id}', [ConsultationController::class, 'update']);
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('/my-schedule', [ConsultationAPIController::class, 'schedule']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationController
Open

    Route::post('consultations/change-term/{consultationTermId}', [ConsultationController::class, 'changeTerm']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationAPIController
Open

    Route::get('/me', [ConsultationAPIController::class, 'forCurrentUser']);
Severity: Critical
Found in src/routes.php by phan

Call to method post from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::post('/change-term/{consultationTermId}', [ConsultationController::class, 'changeTerm']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationAPIController
Open

    Route::post('/finish-term/{consultationTermId}', [ConsultationAPIController::class, 'finishTerm']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Consultations\Http\Controllers\ConsultationAPIController
Open

Route::post('api/consultations/save-screen', [ConsultationAPIController::class, 'screenSave']);
Severity: Critical
Found in src/routes.php by phan

Define a constant instead of duplicating this literal "prefix" 3 times.
Open

Route::group(['middleware' => ['auth:api'], 'prefix' => 'api/admin'], function () {
Severity: Critical
Found in src/routes.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Expected 1 blank line at end of file; 2 found
Open

Route::post('api/consultations/save-screen', [ConsultationAPIController::class, 'screenSave']);
Severity: Minor
Found in src/routes.php by phpcodesniffer

There are no issues that match your filters.

Category
Status