Sign upLogin

EscolaLMS/Core

View on GitHub
Star

Showing 14 of 14 total issues

BaseRepository has 33 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class BaseRepository implements BaseRepositoryContract, UserableRepositoryContract
{
    /**
     * @var Model
     */
Severity: Minor
Found in src/Repositories/BaseRepository.php - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (!Schema::hasTable($tableNames['model_has_roles'])) {
            Schema::create($tableNames['model_has_roles'], function (Blueprint $table) use ($tableNames, $columnNames) {
                $table->unsignedBigInteger('role_id');

                $table->string('model_type');
    Severity: Major
    Found in database/migrations/2020_12_08_055436_create_permission_tables.php and 1 other location - About 4 hrs to fix
    database/migrations/2020_12_08_055436_create_permission_tables.php on lines 41..59

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 163.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (!Schema::hasTable($tableNames['model_has_permissions'])) {
            Schema::create($tableNames['model_has_permissions'], function (Blueprint $table) use ($tableNames, $columnNames) {
                $table->unsignedBigInteger('permission_id');

                $table->string('model_type');
    Severity: Major
    Found in database/migrations/2020_12_08_055436_create_permission_tables.php and 1 other location - About 4 hrs to fix
    database/migrations/2020_12_08_055436_create_permission_tables.php on lines 61..79

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 163.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method up has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function up()
    {
        $tableNames = config('permission.table_names');
        $columnNames = config('permission.column_names');
    Severity: Major
    Found in database/migrations/2020_12_08_055436_create_permission_tables.php - About 2 hrs to fix

      Function allQuery has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function allQuery(array $search = [], ?int $skip = null, ?int $limit = null): Builder
    {
        $query = $this->model->newQuery();

        if (count($search)) {
      Severity: Minor
      Found in src/Repositories/BaseRepository.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method allWithOrder has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function allWithOrder(array $search = [], ?int $skip = null, ?int $limit = null, ?string $orderBy = null, string $direction = 'asc', array $columns = ['*'])
      Severity: Minor
      Found in src/Repositories/BaseRepository.php - About 45 mins to fix

        Method allInUserContextQuery has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function allInUserContextQuery(User $user, array $search = [], ?int $skip = null, ?int $limit = null, array $columns = ['*'], string $user_key = 'user_id'): Builder
        Severity: Minor
        Found in src/Repositories/BaseRepository.php - About 45 mins to fix

          Method all has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function all(array $search = [], ?int $skip = null, ?int $limit = null, array $columns = ['*'], string $orderDirection = 'asc', string $orderColumn = 'id');
          Severity: Minor
          Found in src/Repositories/Contracts/BaseRepositoryContract.php - About 45 mins to fix

            Method allInUserContext has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function allInUserContext(User $user, array $search = [], ?int $skip = null, ?int $limit = null, array $columns = ['*'], string $user_key = 'user_id')
            Severity: Minor
            Found in src/Repositories/BaseRepository.php - About 45 mins to fix

              Method allInUserContextQuery has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function allInUserContextQuery(User $user, array $search = [], ?int $skip = null, ?int $limit = null, array $columns = ['*'], string $user_key = 'user_id'): Builder;
              Severity: Minor
              Found in src/Repositories/Contracts/UserableRepositoryContract.php - About 45 mins to fix

                Method allInUserContext has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function allInUserContext(User $user, array $search = [], ?int $skip = null, ?int $limit = null, array $columns = ['*'], string $user_key = 'user_id');
                Severity: Minor
                Found in src/Repositories/Contracts/UserableRepositoryContract.php - About 45 mins to fix

                  Method all has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function all(array $search = [], ?int $skip = null, ?int $limit = null, array $columns = ['*'], string $orderDirection = 'asc', string $orderColumn = 'id')
                  Severity: Minor
                  Found in src/Repositories/BaseRepository.php - About 45 mins to fix

                    Method allWithOrder has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function allWithOrder(array $search = [], ?int $skip = null, ?int $limit = null, ?string $orderBy = null, string $direction = 'asc', array $columns = ['*']);
                    Severity: Minor
                    Found in src/Repositories/Contracts/BaseRepositoryContract.php - About 45 mins to fix

                      Function up has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function up()
    {
        $tableNames = config('permission.table_names');
        $columnNames = config('permission.column_names');
                      Severity: Minor
                      Found in database/migrations/2020_12_08_055436_create_permission_tables.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language