EscolaLMS/Courses-Import-Export

View on GitHub
src/Http/Resources/CourseExportResource.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid using static access to class 'EscolaLms\CoursesImportExport\Http\Resources\CourseScormScoExportResource' in method 'toArray'.
Open

            'scorm_sco' => $this->when($course->scorm_sco_id !== null, fn () => CourseScormScoExportResource::make($course)),

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'EscolaLms\CoursesImportExport\Http\Resources\LessonExportResource' in method 'toArray'.
Open

            'lessons' => LessonExportResource::collection($course->lessons()->main()->orderBy('order')->get()),

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'EscolaLms\CoursesImportExport\Http\Resources\CategoryExportResource' in method 'toArray'.
Open

            'categories' => CategoryExportResource::collection($course->categories),

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$request'.
Open

    public function toArray($request): array

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Line exceeds 120 characters; contains 125 characters
Open

            'scorm_sco' => $this->when($course->scorm_sco_id !== null, fn () => CourseScormScoExportResource::make($course)),

Space before opening parenthesis of function call prohibited
Open

            'scorm_sco' => $this->when($course->scorm_sco_id !== null, fn () => CourseScormScoExportResource::make($course)),

There are no issues that match your filters.

Category
Status