src/Services/Contracts/ExportImportServiceContract.php
The method export has a boolean flag argument $withUrl, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function export($courseId, bool $withUrl = true): string;- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}