EscolaLMS/Courses-Import-Export

View on GitHub
src/Services/ExportImportService.php

Summary

Maintainability
C
1 day
Test Coverage
A
95%

File ExportImportService.php has 353 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace EscolaLms\CoursesImportExport\Services;

use EscolaLms\Categories\Models\Category;
Severity: Minor
Found in src/Services/ExportImportService.php - About 4 hrs to fix

    The class ExportImportService has an overall complexity of 67 which is very high. The configured complexity threshold is 50.
    Open

    class ExportImportService implements ExportImportServiceContract
    {
        private CourseRepositoryContract $courseRepository;
        private LessonRepositoryContract $lessonRepository;
        private TopicRepositoryContract $topicRepository;
    Severity: Minor
    Found in src/Services/ExportImportService.php by phpmd

    ExportImportService has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ExportImportService implements ExportImportServiceContract
    {
        private CourseRepositoryContract $courseRepository;
        private LessonRepositoryContract $lessonRepository;
        private TopicRepositoryContract $topicRepository;
    Severity: Minor
    Found in src/Services/ExportImportService.php - About 2 hrs to fix

      Method createTopicFromImport has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function createTopicFromImport(array $topicData, string $dirFullPath, int $courseId): ?Model
          {
              if (!isset($topicData['topicable_type'])) {
                  return null;
              }
      Severity: Minor
      Found in src/Services/ExportImportService.php - About 1 hr to fix

        Function createTopicFromImport has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function createTopicFromImport(array $topicData, string $dirFullPath, int $courseId): ?Model
            {
                if (!isset($topicData['topicable_type'])) {
                    return null;
                }
        Severity: Minor
        Found in src/Services/ExportImportService.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                CourseRepositoryContract        $courseRepository,
                LessonRepositoryContract        $lessonRepository,
                TopicRepositoryContract         $topicRepository,
                TopicResourceRepositoryContract $topicResourceRepository,
                CategoriesRepositoryContract    $categoriesRepository
        Severity: Minor
        Found in src/Services/ExportImportService.php - About 35 mins to fix

          Function createLessonFromImport has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function createLessonFromImport(array $lessonData, string $dirFullPath): Model
              {
                  $lessonValidator = Validator::make($lessonData, Lesson::$rules);
                  /** @var Lesson $lesson */
                  $lesson = $this->lessonRepository->create($lessonValidator->validate());
          Severity: Minor
          Found in src/Services/ExportImportService.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function createCourseFromImport has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function createCourseFromImport(array $courseData, string $dirFullPath): Model
              {
                  unset($courseData['author_id']);
          
                  $courseData = $this->addFilesToArrayBasedOnPath($courseData, $dirFullPath);
          Severity: Minor
          Found in src/Services/ExportImportService.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method createTopicFromImport() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
          Open

              private function createTopicFromImport(array $topicData, string $dirFullPath, int $courseId): ?Model
              {
                  if (!isset($topicData['topicable_type'])) {
                      return null;
                  }
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The class ExportImportService has a coupling between objects value of 27. Consider to reduce the number of dependencies under 13.
          Open

          class ExportImportService implements ExportImportServiceContract
          {
              private CourseRepositoryContract $courseRepository;
              private LessonRepositoryContract $lessonRepository;
              private TopicRepositoryContract $topicRepository;
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          CouplingBetweenObjects

          Since: 1.1.0

          A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

          Example

          class Foo {
              /**
               * @var \foo\bar\X
               */
              private $x = null;
          
              /**
               * @var \foo\bar\Y
               */
              private $y = null;
          
              /**
               * @var \foo\bar\Z
               */
              private $z = null;
          
              public function setFoo(\Foo $foo) {}
              public function setBar(\Bar $bar) {}
              public function setBaz(\Baz $baz) {}
          
              /**
               * @return \SplObjectStorage
               * @throws \OutOfRangeException
               * @throws \InvalidArgumentException
               * @throws \ErrorException
               */
              public function process(\Iterator $it) {}
          
              // ...
          }

          Source https://phpmd.org/rules/design.html#couplingbetweenobjects

          Missing class import via use statement (line '113', column '23').
          Open

                      throw new \Exception("Zip file could not be created: " . $zip->getStatusString());
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
              return new \stdClass();
          }

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          The method createZipFromFolder has a boolean flag argument $withUrl, which is a certain sign of a Single Responsibility Principle violation.
          Open

              private function createZipFromFolder($dirName, bool $withUrl = true): string
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          BooleanArgumentFlag

          Since: 1.4.0

          A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

          Example

          class Foo {
              public function bar($flag = true) {
              }
          }

          Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

          Missing class import via use statement (line '122', column '27').
          Open

                          throw new \Exception("File [`{$file}`] could not be added to the zip file: " . $zip->getStatusString());
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
              return new \stdClass();
          }

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          The method export has a boolean flag argument $withUrl, which is a certain sign of a Single Responsibility Principle violation.
          Open

              public function export($courseId, bool $withUrl = true): string
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          BooleanArgumentFlag

          Since: 1.4.0

          A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

          Example

          class Foo {
              public function bar($flag = true) {
              }
          }

          Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

          Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'createExportJson'.
          Open

                  Storage::put($dirName . '/content/content.json', $json);
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'import'.
          Open

                      $content = json_decode(File::get($dirFullPath . DIRECTORY_SEPARATOR . 'content.json'), true);
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\EscolaLms\CoursesImportExport\Models\Course' in method 'createCourseFromImport'.
          Open

                  $courseValidator = Validator::make($courseData, Course::rules());
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\EscolaLms\CoursesImportExport\Models\Course' in method 'fixAllPathsBeforeZipping'.
          Open

                  $course = Course::findOrFail($courseId);
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Validator' in method 'createCourseFromImport'.
          Open

                  $courseValidator = Validator::make($courseData, Course::rules());
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Str' in method 'addFilesToArrayBasedOnPath'.
          Open

                      if (Str::endsWith($key, '_path')
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'copyCourseFilesToExportFolder'.
          Open

                  if (Storage::exists($dirName)) {
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Arr' in method 'createCategories'.
          Open

                  return Arr::flatten($ids);
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'createCategory'.
          Open

                      $category['icon'] = Storage::putFile('categories', $file, 'public');
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Validator' in method 'createLessonFromImport'.
          Open

                  $lessonValidator = Validator::make($lessonData, Lesson::$rules);
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'createTopicResources'.
          Open

                          && File::exists($dirFullPath . DIRECTORY_SEPARATOR . $resource['path'])
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'createZipFromFolder'.
          Open

                  $files = Storage::allFiles($dirName . '/content');
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'createZipFromFolder'.
          Open

                      $content = Storage::get($file);
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'copyCourseFilesToExportFolder'.
          Open

                      Storage::deleteDirectory($dirName);
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'copyCourseFilesToExportFolder'.
          Open

                  Storage::makeDirectory($dirName);
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'createZipFromFolder'.
          Open

                  Storage::deleteDirectory($dirName . '/content');
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Validator' in method 'createTopicFromImport'.
          Open

                  $request->setValidator(Validator::make($topicData, $request->rules()));
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'copyCourseFilesToExportFolder'.
          Open

                  $fromFiles = Storage::allFiles($dirFrom);
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'copyCourseFilesToExportFolder'.
          Open

                      Storage::copy($fromFile, $toFile);
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'import'.
          Open

                      Storage::deleteDirectory($dirPath);
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'createTopicFromImport'.
          Open

                      if (isset($topicData[$key]) && File::exists($dirFullPath . DIRECTORY_SEPARATOR . $topicData[$key])) {
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'addFilesToArrayBasedOnPath'.
          Open

                          && File::exists($dirFullPath . DIRECTORY_SEPARATOR . $value)
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Str' in method 'addFilesToArrayBasedOnPath'.
          Open

                          $fileKey = Str::before($key, '_path');
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\DB' in method 'import'.
          Open

                      $course = DB::transaction(function () use ($content, $dirFullPath) {
                          return $this->createCourseFromImport($content, $dirFullPath);
                      });
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'importRichTextTopicAssets'.
          Open

                      Storage::put($destinationPath . basename($file), $fileToStore);
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\EscolaLms\CoursesImportExport\Http\Resources\CourseExportResource' in method 'createExportJson'.
          Open

                  $program = CourseExportResource::make($course);
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'createCategory'.
          Open

                  if (File::exists($filePath)) {
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'addFilesToArrayBasedOnPath'.
          Open

                          && !File::isDirectory($dirFullPath . DIRECTORY_SEPARATOR . $value)
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Illuminate\Support\Facades\Log' in method 'import'.
          Open

                      Log::error($message);
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid excessively long variable names like $topicResourceRepository. Keep variable name length under 20.
          Open

                  TopicResourceRepositoryContract $topicResourceRepository,
          Severity: Minor
          Found in src/Services/ExportImportService.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
              protected $reallyLongIntName = -3; // VIOLATION - Field
              public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                  $otherReallyLongName = -5; // VIOLATION - Local
                  for ($interestingIntIndex = 0; // VIOLATION - For
                       $interestingIntIndex < 10;
                       $interestingIntIndex++ ) {
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#longvariable

          The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
          Open

              {

          Line exceeds 120 characters; contains 154 characters
          Open

                          return '![' . url('storage/' . $path) . '/' . basename($matches[1]) . '](' . url('storage/' . $path ) . '/' . basename($matches[1]) . ')';

          Line exceeds 120 characters; contains 128 characters
          Open

                  $strategy = 'EscolaLms\\CoursesImportExport\\Strategies\\' . substr(strrchr($topicType, "\\"), 1) . 'TopicTypeStrategy';

          Expected 0 spaces before closing bracket; 1 found
          Open

                          return '![' . url('storage/' . $path) . '/' . basename($matches[1]) . '](' . url('storage/' . $path ) . '/' . basename($matches[1]) . ')';

          There are no issues that match your filters.

          Category
          Status