Sign upLogin

EscolaLMS/Courses

View on GitHub
Star
src/ValueObjects/CourseProgressCollection.php

Summary

Maintainability
B
4 hrs
Test Coverage
A
94%

CourseProgressCollection has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class CourseProgressCollection extends ValueObject implements ValueObjectContract, CourseProgressCollectionContract
{
    public const FORGET_TRACKING_SESSION_AFTER_MINUTES = 60;

    private CourseProgressRepositoryContract $courseProgressRepositoryContract;
Severity: Minor
Found in src/ValueObjects/CourseProgressCollection.php - About 2 hrs to fix

    Method buildProgress has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function buildProgress(): EloquentCollection
    {
        $topicWithProgressId = CourseProgress::where('user_id', $this->user->getKey())->whereIn('topic_id', $this->topics->toArray())->pluck('topic_id')->toArray();
        $topicsWithoutProgress = $this->course
            ->topics()
    Severity: Minor
    Found in src/ValueObjects/CourseProgressCollection.php - About 1 hr to fix

      Function buildProgress has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function buildProgress(): EloquentCollection
    {
        $topicWithProgressId = CourseProgress::where('user_id', $this->user->getKey())->whereIn('topic_id', $this->topics->toArray())->pluck('topic_id')->toArray();
        $topicsWithoutProgress = $this->course
            ->topics()
      Severity: Minor
      Found in src/ValueObjects/CourseProgressCollection.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status