Sign upLogin

EscolaLMS/H5P

View on GitHub
Star

Showing 51 of 59 total issues

Function additionalTranslations has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private function additionalTranslations(array $libraryLanguages, H5PLibrary $library): array
    {
        $additionalLanguageCodes = ['pl'];
        foreach ($additionalLanguageCodes as $languageCode) {
            if (isset($libraryLanguages) && !isset($libraryLanguages[$languageCode])) {
Severity: Minor
Found in src/Repositories/H5PRepository.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function downloadAndSeed has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private function downloadAndSeed($lib, $addContent = false)
    {
        // eg https://h5p.org/sites/default/files/h5p/exports/interactive-video-2-618.h5p
        $url = "https://h5p.org/sites/default/files/h5p/exports/$lib";
Severity: Minor
Found in database/seeders/ContentLibrarySeeder.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function downloadAndSeed has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private function downloadAndSeed($lib, $addContent = false)
    {
        // eg https://h5p.org/sites/default/files/h5p/exports/interactive-video-2-618.h5p
        $url = "https://h5p.org/sites/default/files/h5p/exports/$lib";
Severity: Minor
Found in src/Commands/H5PSeedCommand.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function generateContentSlug has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private function generateContentSlug($content) {
        $slug = H5PCore::slugify($content['title']);

        $available = NULL;
        while (!$available) {
Severity: Minor
Found in src/Services/H5PCoreService.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in src/Repositories/H5PRepository.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return false;
    Severity: Major
    Found in src/Repositories/H5PRepository.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return true;
      Severity: Major
      Found in src/Repositories/H5PRepository.php - About 30 mins to fix

        Function libraryInstall has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function libraryInstall($machineName)
    {
        // Determine which content type to install from post data
        if (!$machineName) {
            throw new H5PException(H5PException::NO_CONTENT_TYPE);
        Severity: Minor
        Found in src/Services/HeadlessH5PService.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getContentSettings has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getContentSettings($id, ?string $token = null): array
    {
        $lang = config('hh5p.language');

        // READ this https://h5p.org/creating-your-own-h5p-plugin
        Severity: Minor
        Found in src/Services/HeadlessH5PService.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getLanguage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getLanguage($machineName, $majorVersion, $minorVersion, $language): ?string
    {
        if (!isset($language)) {
            return null;
        }
        Severity: Minor
        Found in src/Repositories/H5PEditorStorageRepository.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function instantiateFromRequest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function instantiateFromRequest(Request $request): self
    {
        $criteria = new Collection();
        $user = auth()->user();
        Severity: Minor
        Found in src/Dtos/ContentFilterCriteriaDto.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language