Sign upLogin

EscolaLMS/H5P

View on GitHub
Star

Showing 62 of 62 total issues

File H5PRepository.php has 678 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace EscolaLms\HeadlessH5P\Repositories;

use EscolaLms\HeadlessH5P\Exceptions\H5PException;
Severity: Major
Found in src/Repositories/H5PRepository.php - About 1 day to fix

    File HeadlessH5PService.php has 601 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace EscolaLms\HeadlessH5P\Services;

use EscolaLms\HeadlessH5P\Exceptions\H5PException;
    Severity: Major
    Found in src/Services/HeadlessH5PService.php - About 1 day to fix

      H5PRepository has 65 functions (exceeds 20 allowed). Consider refactoring.
      Confirmed

      class H5PRepository implements H5PFrameworkInterface
{

    private H5PLibraryLanguageRepositoryContract $h5PLibraryLanguageRepository;
      Severity: Major
      Found in src/Repositories/H5PRepository.php - About 1 day to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            'content' => [
        'creator' => 'Creator',
        'created_at' => 'Created At',
        'title' => 'Title',
        'content_type' => 'Content Type',
        Severity: Major
        Found in resources/lang/en/h5p.php and 1 other location - About 5 hrs to fix
        resources/lang/pl/h5p.php on lines 10..47

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 186.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            'content' => [
        'creator' => 'Kreator',
        'created_at' => 'Utworzony w',
        'title' => 'Tytuł',
        'content_type' => 'Typ zawartości',
        Severity: Major
        Found in resources/lang/pl/h5p.php and 1 other location - About 5 hrs to fix
        resources/lang/en/h5p.php on lines 10..47

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 186.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            'library' => [
        'title' => 'Title',
        'name' => 'Name',
        'version' => 'Version',
        'restricted' => 'Restricted',
        Severity: Major
        Found in resources/lang/en/h5p.php and 1 other location - About 4 hrs to fix
        resources/lang/pl/h5p.php on lines 48..82

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 171.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            'library' => [
        'title' => 'Tytuł',
        'name' => 'Nazwa',
        'version' => 'Wersja',
        'restricted' => 'Restricted',
        Severity: Major
        Found in resources/lang/pl/h5p.php and 1 other location - About 4 hrs to fix
        resources/lang/en/h5p.php on lines 48..82

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 171.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        HeadlessH5PService has 34 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class HeadlessH5PService implements HeadlessH5PServiceContract
{
    private H5PFrameworkInterface $repository;
    private H5PFileStorage $fileStorage;
    private H5PCore $core;
        Severity: Minor
        Found in src/Services/HeadlessH5PService.php - About 4 hrs to fix

          Function createExportFile has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
          Open

              public function createExportFile($content) {
        // Get path to temporary folder, where export will be contained
        $tmpPath = $this->h5pC->fs->getTmpPath();
        Storage::createDirectory($tmpPath);
          Severity: Minor
          Found in src/Services/H5PExportService.php - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getEditorSettings has 100 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getEditorSettings($content = null): array
    {
        $lang = config('hh5p.language');

        $config = $this->getConfig();
          Severity: Major
          Found in src/Services/HeadlessH5PService.php - About 4 hrs to fix

            Function fixContentParamsMetadataLibraryTitle has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
            Open

                private function fixContentParamsMetadataLibraryTitle($content)
    {
        $defaultTitle = isset($this->mainData['title']) ? $this->mainData['title'] : 'New Content (from file)';

        if (is_array($content['library'])) {
            Severity: Minor
            Found in src/Repositories/H5PRepository.php - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method createExportFile has 91 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function createExportFile($content) {
        // Get path to temporary folder, where export will be contained
        $tmpPath = $this->h5pC->fs->getTmpPath();
        Storage::createDirectory($tmpPath);
            Severity: Major
            Found in src/Services/H5PExportService.php - About 3 hrs to fix

              Function fixCaseKeysArray has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function fixCaseKeysArray($keys, $array)
    {
        if (is_object($array)) {
            $row = $array;
            foreach ($keys as $key) {
              Severity: Minor
              Found in src/Helpers/Helpers.php - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method getContentSettings has 88 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getContentSettings($id, ?string $token = null): array
    {
        $lang = config('hh5p.language');

        // READ this https://h5p.org/creating-your-own-h5p-plugin
              Severity: Major
              Found in src/Services/HeadlessH5PService.php - About 3 hrs to fix

                File h5p.js has 305 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                H5PEditor.language.core = {
    missingTranslation: '[Brakujące tłumaczenie :key]',
    loading: 'Wczytywanie proszę czekać...',
    selectLibrary: 'Wybierz typ zasobu, którego chcesz użyć.',
    unknownFieldPath: 'Nie można odnaleźć ":path".',
                Severity: Minor
                Found in resources/lang/pl/h5p.js - About 3 hrs to fix

                  Function filterParameters has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function filterParameters(&$content)
    {
        if (!empty($content['filtered']) &&
            (!$this->exportEnabled ||
                ($content['slug'] &&
                  Severity: Minor
                  Found in src/Services/H5PCoreService.php - About 3 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  H5PLibrary has 23 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class H5PLibrary extends Model
{
    use HasFactory, QueryCacheable;

    protected $table = 'hh5p_libraries';
                  Severity: Minor
                  Found in src/Models/H5PLibrary.php - About 2 hrs to fix

                    Method fixContentParamsMetadataLibraryTitle has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private function fixContentParamsMetadataLibraryTitle($content)
    {
        $defaultTitle = isset($this->mainData['title']) ? $this->mainData['title'] : 'New Content (from file)';

        if (is_array($content['library'])) {
                    Severity: Major
                    Found in src/Repositories/H5PRepository.php - About 2 hrs to fix

                      Method run has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function run(HeadlessH5PServiceContract $hh5pService)
    {
        $addContent = true;

        $this->hh5pService = $hh5pService;
                      Severity: Major
                      Found in database/seeders/ContentLibrarySeeder.php - About 2 hrs to fix

                        Method handle has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function handle(HeadlessH5PServiceContract $hh5pService)
    {
        $addContent = $this->option('addContent');

        $this->hh5pService = $hh5pService;
                        Severity: Major
                        Found in src/Commands/H5PSeedCommand.php - About 2 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language