EscolaLMS/H5P

View on GitHub

Showing 54 of 62 total issues

Method cacheAssets has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function cacheAssets(&$files, $key)
    {
        foreach ($files as $type => $assets) {
            if (empty($assets)) {
                continue; // Skip no assets
Severity: Minor
Found in src/Repositories/H5PFileStorageRepository.php - About 1 hr to fix

    Function handle has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function handle()
        {
            $relative = $this->option('relative');
            $overwrite = $this->option('overwrite');
    
    
    Severity: Minor
    Found in src/Commands/StorageH5PLinkCommand.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method saveLibraryUsage has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function saveLibraryUsage($contentId, $librariesInUse)
        {
            $contentLibraries = array_map(function ($value) use ($contentId) {
                $contentLibrary = H5PContentLibrary::query()
                    ->where([
    Severity: Minor
    Found in src/Repositories/H5PRepository.php - About 1 hr to fix

      Method edit has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function edit(int $id, string $library, string $params, string $nonce): int
          {
              $content = H5PContent::where('id', $id)->first();
              $previousLib = H5PLibrary::where('id', $content->library_id)->first();
      
      
      Severity: Minor
      Found in src/Repositories/H5PContentRepository.php - About 1 hr to fix

        Method down has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function down()
            {
                if (strpos(DB::connection()->getName(), 'sqlite') !== FALSE) { 
                    return;
                }

          Method getSettingsForContent has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getSettingsForContent($id): array
              {
                  $content = $this->getCore()->loadContent($id);
                  $content['metadata']['title'] = $content['title'];
          
          
          Severity: Minor
          Found in src/Services/HeadlessH5PService.php - About 1 hr to fix

            Method replaceContentTypeCache has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function replaceContentTypeCache($contentTypeCache)
                {
                    $data = [];
                    foreach ($contentTypeCache->contentTypes as $ct) {
                       $data[] = [
            Severity: Minor
            Found in src/Repositories/H5PRepository.php - About 1 hr to fix

              Method downloadAndSeed has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function downloadAndSeed($lib, $addContent = false)
                  {
                      // eg https://h5p.org/sites/default/files/h5p/exports/interactive-video-2-618.h5p
                      $url = "https://h5p.org/sites/default/files/h5p/exports/$lib";
              
              
              Severity: Minor
              Found in database/seeders/ContentLibrarySeeder.php - About 1 hr to fix

                Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        H5PFrameworkInterface  $repository,
                        H5PFileStorage         $fileStorage,
                        H5PCore                $core,
                        H5PValidator           $validator,
                        H5PStorage             $storage,
                Severity: Major
                Found in src/Services/HeadlessH5PService.php - About 1 hr to fix

                  Method getLibraries has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getLibraries(string $machineName = null, string $major_version = null, string $minor_version = null, int $library_id = null)
                      {
                          $lang = config('hh5p.language');
                          $libraries_url = Storage::url(config('hh5p.h5p_library_url'));
                  
                  
                  Severity: Minor
                  Found in src/Services/HeadlessH5PService.php - About 1 hr to fix

                    Function textAddonMatches has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function textAddonMatches($params, $pattern, $found = false) {
                            $type = gettype($params);
                            if ($type === 'string') {
                                if (preg_match($pattern, $params) === 1) {
                                    return true;
                    Severity: Minor
                    Found in src/Services/H5PCoreService.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function copyVendorFiles has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function copyVendorFiles($source, $destination) {
                            if (!$this->isDirReady($destination)) {
                                throw new Exception('unabletocopy');
                            }
                    
                    
                    Severity: Minor
                    Found in src/Repositories/H5PFileStorageRepository.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function cacheAssets has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function cacheAssets(&$files, $key)
                        {
                            foreach ($files as $type => $assets) {
                                if (empty($assets)) {
                                    continue; // Skip no assets
                    Severity: Minor
                    Found in src/Repositories/H5PFileStorageRepository.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function copyFiles has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function copyFiles($source, $destination) {
                            if (!$this->isDirReady($destination)) {
                                throw new Exception('unabletocopy');
                            }
                    
                    
                    Severity: Minor
                    Found in src/Repositories/H5PFileStorageRepository.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method saveLibraryData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Confirmed

                        public function saveLibraryData(&$libraryData, $new = true)
                        {
                            $library = [
                                'name' => $libraryData['machineName'],
                                'title' => $libraryData['title'],
                    Severity: Minor
                    Found in src/Repositories/H5PRepository.php - About 1 hr to fix

                      Method fetchExternalData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function fetchExternalData($url, $data = null, $blocking = true, $stream = null, $fullData = false, $headers = [], $files = [], $method = 'POST')
                          {
                              @set_time_limit(0);
                              $options = [
                                  'timeout'  => !empty($blocking) ? 30 : 0.01,
                      Severity: Minor
                      Found in src/Repositories/H5PRepository.php - About 1 hr to fix

                        Method fetchExternalData has 8 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function fetchExternalData($url, $data = null, $blocking = true, $stream = null, $fullData = false, $headers = [], $files = [], $method = 'POST')
                        Severity: Major
                        Found in src/Repositories/H5PRepository.php - About 1 hr to fix

                          Function getEditorSettings has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function getEditorSettings($content = null): array
                              {
                                  $lang = config('hh5p.language');
                          
                                  $config = $this->getConfig();
                          Severity: Minor
                          Found in src/Services/HeadlessH5PService.php - About 55 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function fetchExternalData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function fetchExternalData($url, $data = null, $blocking = true, $stream = null, $fullData = false, $headers = [], $files = [], $method = 'POST')
                              {
                                  @set_time_limit(0);
                                  $options = [
                                      'timeout'  => !empty($blocking) ? 30 : 0.01,
                          Severity: Minor
                          Found in src/Repositories/H5PRepository.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              public function __construct(H5PFrameworkInterface $H5PFramework, $path, $url, $language = 'en', $export = FALSE)
                          Severity: Minor
                          Found in src/Services/H5PCoreService.php - About 35 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language