Sign upLogin

EscolaLMS/Jitsi

View on GitHub
Star

Showing 12 of 12 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace EscolaLms\Jitsi\Exceptions;

use Exception;
Severity: Major
Found in src/Exceptions/InvalidJitsiFqnException.php and 1 other location - About 2 hrs to fix
src/Exceptions/RecordedVideoSaveException.php on lines 1..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace EscolaLms\Jitsi\Exceptions;

use Exception;
Severity: Major
Found in src/Exceptions/RecordedVideoSaveException.php and 1 other location - About 2 hrs to fix
src/Exceptions/InvalidJitsiFqnException.php on lines 1..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method getChannelData has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getChannelData(
        User $user,
        string $channelDisplayName,
        bool $isModerator = false,
        array $configOverwrite = [],
Severity: Minor
Found in src/Services/JitsiService.php - About 2 hrs to fix

    Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct(array $participants, string $initiatorId, int $durationSec, string $startTimestamp, string $endTimestamp, string $recordingSessionId, string $preAuthenticatedLink, bool|null $share)
    Severity: Major
    Found in src/Dto/RecordedVideoDataDto.php - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function generateJwt(array $data): ?string
    {
        if (isset($data[0]) && $this->shouldGenerateJWT()) {
            $this->jaasService->setConfig($this->config);
            return $this->jaasService->generateJwt(
      Severity: Minor
      Found in src/Strategies/VideoConferenceMode/JaasVideoConferenceModeStrategy.php and 1 other location - About 55 mins to fix
      src/Strategies/VideoConferenceMode/JitsiVideoConferenceModeStrategy.php on lines 19..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 98.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function generateJwt(array $data): ?string
    {
        if (isset($data[0]) && $this->shouldGenerateJWT()) {
            $this->jitsiService->setConfig($this->config);
            return $this->jitsiService->generateJwt(
      Severity: Minor
      Found in src/Strategies/VideoConferenceMode/JitsiVideoConferenceModeStrategy.php and 1 other location - About 55 mins to fix
      src/Strategies/VideoConferenceMode/JaasVideoConferenceModeStrategy.php on lines 19..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 98.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct(string $eventType, string $timestamp, string $sessionId, string $fqn, string $appId, array $data)
      Severity: Minor
      Found in src/Dto/RecordedVideoDto.php - About 45 mins to fix

        Method getChannelData has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                User $user,
        string $channelDisplayName,
        bool $isModerator = false,
        array $configOverwrite = [],
        $interfaceConfigOverwrite = []
        Severity: Minor
        Found in src/Services/Contracts/JaasServiceContract.php - About 35 mins to fix

          Method getChannelData has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  User $user,
        string $channelDisplayName,
        bool $isModerator = false,
        array $configOverwrite = [],
        $interfaceConfigOverwrite = []
          Severity: Minor
          Found in src/Services/JitsiService.php - About 35 mins to fix

            Method convertToJitsiSlug has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public static function convertToJitsiSlug(string $str, array $options = [], string|null $type = null, int|null $modelId = null, string|null $subModel = null): string
            Severity: Minor
            Found in src/Helpers/StringHelper.php - About 35 mins to fix

              Method getChannelData has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      User $user,
        string $channelDisplayName,
        bool $isModerator = false,
        array $configOverwrite = [],
        $interfaceConfigOverwrite = []
              Severity: Minor
              Found in src/Services/Contracts/JitsiServiceContract.php - About 35 mins to fix

                Function recordedVideo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function recordedVideo(RecordedVideoDto $dto): void
    {
        $appId = config('jitsi.app_id');
        if (!Str::startsWith($dto->getFqn(), $appId . '/')) {
            throw new InvalidJitsiFqnException();
                Severity: Minor
                Found in src/Services/JitsiVideoService.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language