EscolaLMS/Webinar

View on GitHub
database/migrations/2022_02_15_141832_create_webinars_table.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'down'.
Open

        Schema::dropIfExists('webinars');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'up'.
Open

        Schema::create('webinars', function (Blueprint $table) {
            $table->id();
            $table->bigInteger('author_id')->unsigned()->nullable();
            $table->integer('base_price')->nullable();
            $table->string('name', 255);

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to method id from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->id();

Call to method string from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->string('status')->default(WebinarStatusEnum::DRAFT);

Call to method string from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->string('name', 255);

Class extends undeclared class \Illuminate\Database\Migrations\Migration
Open

class CreateWebinarsTable extends Migration

Call to method create from undeclared class \Illuminate\Support\Facades\Schema
Open

        Schema::create('webinars', function (Blueprint $table) {

Call to method dropIfExists from undeclared class \Illuminate\Support\Facades\Schema
Open

        Schema::dropIfExists('webinars');

Parameter $table has undeclared type \Illuminate\Database\Schema\Blueprint
Open

        Schema::create('webinars', function (Blueprint $table) {

Call to method text from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->text('description');

Call to method foreign from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->foreign('author_id')->references('id')->on('users')->onDelete('SET NULL');

Call to method bigInteger from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->bigInteger('author_id')->unsigned()->nullable();

Call to method string from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->string('duration')->nullable();

Call to method integer from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->integer('base_price')->nullable();

Call to method dateTime from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->dateTime('active_from')->nullable();

Call to method dateTime from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->dateTime('active_to')->nullable();

Call to method timestamps from undeclared class \Illuminate\Database\Schema\Blueprint
Open

            $table->timestamps();

Avoid using short method names like CreateWebinarsTable::up(). The configured minimum method name length is 3.
Open

    public function up(): void
    {
        Schema::create('webinars', function (Blueprint $table) {
            $table->id();
            $table->bigInteger('author_id')->unsigned()->nullable();

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class CreateWebinarsTable extends Migration

There are no issues that match your filters.

Category
Status