Sign upLogin

EscolaLMS/Webinar

View on GitHub
Star

Showing 636 of 636 total issues

Avoid using static access to class 'EscolaLms\Webinar\Http\Resources\TrainerResource' in method 'toArray'.
Open

            'trainers' => TrainerResource::collection($this->resource->trainers),
Severity: Minor
Found in src/Http/Resources/WebinarSimpleResource.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'getLogotypeUrlAttribute'.
Open

                $logotype = Storage::url(trim($this->attributes['logotype_path'], '/'));
Severity: Minor
Found in src/Models/Webinar.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Carbon\Carbon' in method 'toArray'.
Open

            'active_to' => Carbon::make($this->resource->active_to),
Severity: Minor
Found in src/Http/Resources/WebinarSimpleResource.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused local variables such as '$oa'.
Open

                return preg_match('/^(http|https):.*$/', $imagePath, $oa) ?
Severity: Minor
Found in src/Models/Webinar.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid using static access to class '\Illuminate\Support\Facades\Storage' in method 'getImageUrlAttribute'.
Open

                $imagePath = Storage::url($path);
Severity: Minor
Found in src/Models/Webinar.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EscolaLms\Webinar\Database\Factories\WebinarFactory' in method 'newFactory'.
Open

        return WebinarFactory::new();
Severity: Minor
Found in src/Models/Webinar.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused local variables such as '$oa'.
Open

                return preg_match('/^(http|https):.*$/', $logotype, $oa) ?
Severity: Minor
Found in src/Models/Webinar.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid using static access to class '\EscolaLms\Webinar\Tests\Database\Factories\UserFactory' in method 'newFactory'.
Open

        return UserFactory::new();
Severity: Minor
Found in src/Models/User.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method prepareFilters() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
Open

    public static function prepareFilters(array $search)
    {
        $dto = new self($search);
        $user = auth()->user();
Severity: Minor
Found in src/Dto/FilterListDto.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Only one argument is allowed per line in a multi-line function call
Open

            $query->orWhereHas('users', fn ($query) =>
Severity: Minor
Found in src/Repositories/WebinarRepository.php by phpcodesniffer

Only one argument is allowed per line in a multi-line function call
Open

            $query->orWhereHas('trainers', fn ($query) =>
Severity: Minor
Found in src/Repositories/WebinarRepository.php by phpcodesniffer

Only one argument is allowed per line in a multi-line function call
Open

        return $query->whereHas('tags', fn (Builder $query) =>
Severity: Minor
Found in src/Repositories/Criteria/WebinarTagsCriterion.php by phpcodesniffer

Line exceeds 120 characters; contains 204 characters
Open

                           WHEN SUBSTRING_INDEX(duration, ' ', -1) = 'seconds' or SUBSTRING_INDEX(duration, ' ', -1) = 'second' THEN DATE_ADD(active_to, INTERVAL SUBSTRING_INDEX(duration, ' ', 1) SECOND )
Severity: Minor
Found in src/Repositories/Criteria/WebinarIncomingCriterion.php by phpcodesniffer

Line exceeds 120 characters; contains 132 characters
Open

            $dto->addToCriteria(new WhereCriterion($dto->model()->getTable() . '.active_to', $dto->getDateTimeToLowerThan(), '>='));
Severity: Minor
Found in src/Dto/FilterListDto.php by phpcodesniffer

Line exceeds 120 characters; contains 129 characters
Open

        if ($user && $user->can(WebinarPermissionsEnum::WEBINAR_LIST_OWN) && !$user->can(WebinarPermissionsEnum::WEBINAR_LIST)) {
Severity: Minor
Found in src/Dto/FilterListDto.php by phpcodesniffer

Line exceeds 120 characters; contains 142 characters
Open

                return Str::startsWith($logotypePath, ConstantEnum::DIRECTORY) ? $logotypePath : ConstantEnum::DIRECTORY . '/' .$logotypePath;
Severity: Minor
Found in src/Dto/WebinarDto.php by phpcodesniffer

Line exceeds 120 characters; contains 149 characters
Open

            'event_start_date_time' => $webinar->active_to ? Carbon::make($webinar->active_to)->format('Y-m-d H:i:s') : now()->format('Y-m-d H:i:s'),
Severity: Minor
Found in src/Services/WebinarService.php by phpcodesniffer

Line exceeds 120 characters; contains 127 characters
Open

            $dto->addToCriteria(new WhereCriterion($dto->model()->getTable() . '.active_from', $dto->getDateTimeFrom(), '>='));
Severity: Minor
Found in src/Dto/FilterListDto.php by phpcodesniffer

Line exceeds 120 characters; contains 172 characters
Open

                           ->whereRaw("active_to + CASE WHEN (duration ~ '^\\d+$') THEN (duration || ' hours')::interval ELSE (duration)::interval END > ?", [$this->value])
Severity: Minor
Found in src/Repositories/Criteria/WebinarIncomingCriterion.php by phpcodesniffer

Line exceeds 120 characters; contains 204 characters
Open

                           WHEN SUBSTRING_INDEX(duration, ' ', -1) = 'minutes' or SUBSTRING_INDEX(duration, ' ', -1) = 'minute' THEN DATE_ADD(active_to, INTERVAL SUBSTRING_INDEX(duration, ' ', 1) MINUTE )
Severity: Minor
Found in src/Repositories/Criteria/WebinarIncomingCriterion.php by phpcodesniffer
Severity
Category
Status
Source
Language