Sign upLogin

EscolaLMS/Webinar

View on GitHub
Star

Showing 636 of 636 total issues

Avoid excessively long variable names like $webinarServiceContract. Keep variable name length under 20.
Open

        $webinarServiceContract = app(WebinarServiceContract::class);
Severity: Minor
Found in src/Models/Webinar.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $webinarServiceContract. Keep variable name length under 20.
Open

        $webinarServiceContract = app(WebinarServiceContract::class);
Severity: Minor
Found in src/Jobs/ReminderAboutWebinarJob.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $webinarServiceContract. Keep variable name length under 20.
Open

        WebinarServiceContract $webinarServiceContract
Severity: Minor
Found in src/Listeners/ReminderAboutTermListener.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $webinarServiceContract. Keep variable name length under 20.
Open

        $webinarServiceContract = app(WebinarServiceContract::class);
Severity: Minor
Found in src/Models/Webinar.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Method prepareFilters has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function prepareFilters(array $search)
    {
        $dto = new self($search);
        $user = auth()->user();
Severity: Minor
Found in src/Dto/FilterListDto.php - About 1 hr to fix

    Function prepareFilters has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function prepareFilters(array $search)
    {
        $dto = new self($search);
        $user = auth()->user();
    Severity: Minor
    Found in src/Dto/FilterListDto.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid using short method names like AddImagePathColumnToWebinarsTable::up(). The configured minimum method name length is 3.
    Open

        public function up(): void
    {
        Schema::table('webinars', function (Blueprint $table) {
            $table->string('image_path')->nullable();
        });
    Severity: Minor
    Found in database/migrations/2022_02_23_144037_add_image_path_column_to_webinars_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like RemoveNotUsedColumnsFromWebinarTable::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        Schema::table('webinars', function (Blueprint $table) {
            $table->dropColumn('base_price');
        });
    Severity: Minor
    Found in database/migrations/2022_04_19_124520_remove_not_used_columns_from_webinar_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like AddCcolumnsYTForWebinarTable::up(). The configured minimum method name length is 3.
    Open

        public function up(): void
    {
        Schema::table('webinars', function (Blueprint $table) {
            $table->string('yt_id', 30)->nullable();
            $table->string('yt_url', 255)->nullable();
    Severity: Minor
    Found in database/migrations/2022_03_04_152905_add_ccolumns_y_t_for_webinar_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like CreateWebinarAuthorsTable::up(). The configured minimum method name length is 3.
    Open

        public function up(): void
    {
        Schema::create('webinar_authors', function (Blueprint $table) {
            $table->id();
            $table->bigInteger('author_id')->unsigned();
    Severity: Minor
    Found in database/migrations/2022_02_23_125155_create_webinar_authors_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like ChangeNameColumnsInWebinarAuthorsTable::up(). The configured minimum method name length is 3.
    Open

        public function up(): void
    {
        Schema::rename('webinar_authors', 'webinar_trainers');
        Schema::table('webinar_trainers', function (Blueprint $table) {
            $table->dropForeign('webinar_authors_author_id_foreign');
    Severity: Minor
    Found in database/migrations/2022_03_23_111023_change_name_columns_in_webinar_authors_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like CreateWebinarsTable::up(). The configured minimum method name length is 3.
    Open

        public function up(): void
    {
        Schema::create('webinars', function (Blueprint $table) {
            $table->id();
            $table->bigInteger('author_id')->unsigned()->nullable();
    Severity: Minor
    Found in database/migrations/2022_02_15_141832_create_webinars_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like AddTableRelationsUsersWebinar::up(). The configured minimum method name length is 3.
    Open

        public function up(): void
    {
        Schema::create('webinar_user', function (Blueprint $table) {
            $table->id();
            $table->unsignedBigInteger('user_id');
    Severity: Minor
    Found in database/migrations/2022_03_18_143236_add_table_relations_users_webinar.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like AddColumnYtAutoStartStatusInWebinarsTable::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        Schema::table('webinars', function (Blueprint $table) {
            $table->boolean('yt_autostart_status')->default(false)->nullable();
        });
    Severity: Minor
    Found in database/migrations/2022_04_15_132140_add_column_yt_auto_start_status_in_webinars_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like AddMissingColumnsToWebinarsTable::up(). The configured minimum method name length is 3.
    Open

        public function up(): void
    {
        Schema::table('webinars', function (Blueprint $table) {
            $table->text('short_desc')->nullable();
            $table->text('agenda')->nullable();
    Severity: Minor
    Found in database/migrations/2022_03_21_114557_add_missing_columns_to_webinars_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like AddSenderStatusInWebinar::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        Schema::table('webinars', function (Blueprint $table) {
            $table->string('reminder_status', 30)->nullable();
        });
    Severity: Minor
    Found in database/migrations/2022_03_31_072718_add_sender_status_in_webinar.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like AddLogotypeColumnInWebinarsTable::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        Schema::table('webinars', function (Blueprint $table) {
            $table->string('logotype_path')->nullable();
        });
    Severity: Minor
    Found in database/migrations/2022_04_08_100912_add_logotype_column_in_webinars_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Method generateJitsi has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function generateJitsi(int $webinarId): array
    {
        /** @var Webinar|null $webinar */
        $webinar = $this->webinarRepositoryContract->find($webinarId);
        if (!$webinar || !$this->canGenerateJitsi($webinar)) {
    Severity: Minor
    Found in src/Services/WebinarService.php - About 1 hr to fix

      Method apply has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function apply(Builder $query): Builder
    {
        if ($this->withDuration) {
            return $query
                ->where(function (Builder $query) {
      Severity: Minor
      Found in src/Repositories/Criteria/WebinarIncomingCriterion.php - About 1 hr to fix

        Each class must be in a namespace of at least one level (a top-level vendor name)
        Open

        class AddMissingColumnsToWebinarsTable extends Migration
        Severity: Minor
        Found in database/migrations/2022_03_21_114557_add_missing_columns_to_webinars_table.php by phpcodesniffer
        Severity
        Category
        Status
        Source
        Language