Sign upLogin

EscolaLMS/Webinar

View on GitHub
Star
src/Dto/FilterListDto.php

Summary

Maintainability
B
5 hrs
Test Coverage

FilterListDto has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class FilterListDto extends BaseDto
{
    private string $name;
    private array $status;
    private array $reminderStatus;
Severity: Minor
Found in src/Dto/FilterListDto.php - About 2 hrs to fix

    Method prepareFilters has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function prepareFilters(array $search)
    {
        $dto = new self($search);
        $user = auth()->user();
    Severity: Minor
    Found in src/Dto/FilterListDto.php - About 1 hr to fix

      Function prepareFilters has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function prepareFilters(array $search)
    {
        $dto = new self($search);
        $user = auth()->user();
      Severity: Minor
      Found in src/Dto/FilterListDto.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method prepareFilters() has an NPath complexity of 4096. The configured NPath complexity threshold is 200.
      Open

          public static function prepareFilters(array $search)
    {
        $dto = new self($search);
        $user = auth()->user();
      Severity: Minor
      Found in src/Dto/FilterListDto.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
    function bar() {
        // lots of complicated code
    }
}

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method prepareFilters() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
      Open

          public static function prepareFilters(array $search)
    {
        $dto = new self($search);
        $user = auth()->user();
      Severity: Minor
      Found in src/Dto/FilterListDto.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Avoid using static access to class '\EscolaLms\Webinar\Models\Webinar' in method 'model'.
      Open

              return Webinar::newModelInstance();
      Severity: Minor
      Found in src/Dto/FilterListDto.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid unused private methods such as 'addToCriteria'.
      Open

          private function addToCriteria($value): void
    {
        $this->criteria[] = $value;
    }
      Severity: Minor
      Found in src/Dto/FilterListDto.php by phpmd

      UnusedPrivateMethod

      Since: 0.2

      Unused Private Method detects when a private method is declared but is unused.

      Example

      class Something
{
    private function foo() {} // unused
}

      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

      syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
      Open

          private string $name;
      Severity: Critical
      Found in src/Dto/FilterListDto.php by phan

      Line exceeds 120 characters; contains 123 characters
      Open

                  $dto->addToCriteria(new WhereCriterion($dto->model()->getTable() . '.active_to', $dto->getDateTimeTo(), '<='));
      Severity: Minor
      Found in src/Dto/FilterListDto.php by phpcodesniffer

      Line exceeds 120 characters; contains 132 characters
      Open

                  $dto->addToCriteria(new WhereCriterion($dto->model()->getTable() . '.active_to', $dto->getDateTimeToLowerThan(), '>='));
      Severity: Minor
      Found in src/Dto/FilterListDto.php by phpcodesniffer

      Line exceeds 120 characters; contains 125 characters
      Open

                  $dto->addToCriteria(new WebinarIncomingCriterion(now()->format('Y-m-d H:i:s'), $dto->getIncomingWithDuration()));
      Severity: Minor
      Found in src/Dto/FilterListDto.php by phpcodesniffer

      Line exceeds 120 characters; contains 129 characters
      Open

              if ($user && $user->can(WebinarPermissionsEnum::WEBINAR_LIST_OWN) && !$user->can(WebinarPermissionsEnum::WEBINAR_LIST)) {
      Severity: Minor
      Found in src/Dto/FilterListDto.php by phpcodesniffer

      Line exceeds 120 characters; contains 122 characters
      Open

                  $dto->addToCriteria(new DateCriterion($dto->model()->getTable() . '.active_from', $dto->getDateFrom(), '>='));
      Severity: Minor
      Found in src/Dto/FilterListDto.php by phpcodesniffer

      Line exceeds 120 characters; contains 127 characters
      Open

                  $dto->addToCriteria(new WhereCriterion($dto->model()->getTable() . '.active_from', $dto->getDateTimeFrom(), '>='));
      Severity: Minor
      Found in src/Dto/FilterListDto.php by phpcodesniffer

      Line exceeds 120 characters; contains 140 characters
      Open

                  $dto->addToCriteria(new WhereNotInOrIsNullCriterion($dto->model()->getTable() . '.reminder_status', $dto->getReminderStatus()));
      Severity: Minor
      Found in src/Dto/FilterListDto.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status